iox-#2184 Enable clang-tidy for all of hoofs

[elBoberido]

Pre-Review Checklist for the PR Author

1. [x] Add a second reviewer for complex new features or larger refactorings
2. [x] Code follows the coding style of CONTRIBUTING.md
3. [x] Tests follow the best practice for testing
4. [x] Changelog updated in the unreleased section including API breaking changes
5. [x] Branch follows the naming format (iox-123-this-is-a-branch)
6. [x] Commits messages are according to this guideline
   • [x] Commit messages have the issue ID (iox-#123 commit text)
   • [x] Commit author matches Eclipse Contributor Agreement (and ECA is signed)
7. [x] Update the PR title
   • Follow the same conventions as for commit messages
   • Link to the relevant issue
8. [x] Relevant issues are linked
9. [x] Add sensible notes for the reviewer
10. [x] All checks have passed (except task-list-completed)
11. [x] All touched (C/C++) source code files from iceoryx_hoofs are added to ./clang-tidy-diff-scans.txt
12. [x] Assign PR to reviewer

Notes for Reviewer

The PR adds all files of iceoryx_hoofs to the list of files to scan by clang-tidy and fixes the clang-tidy warnings on the new files.

Checklist for the PR Reviewer

• [x] Commits are properly organized and messages are according to the guideline
• [x] Code according to our coding style and naming conventions
• [x] Unit tests have been written for new behavior
• [x] Public API changes are documented via doxygen
• [x] Copyright owner are updated in the changed files
• [x] All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
• [x] PR title describes the changes

Post-review Checklist for the PR Author

1. [x] All open points are addressed and tracked via issues

References

• Closes #2184

[elBoberido]

@FerdinandSpitzschnueffler @mossmaurice @dkroenke @MatthiasKillat @budrus @elfenpiff feel free to add yourself as reviewer

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (5866693) 79.97% compared to head (f8ca98c) 79.94%. Report is 1 commits behind head on master.

Additional details and impacted files

[](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2187?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) ```diff @@ Coverage Diff @@ ## master #2187 +/- ## ========================================== - Coverage 79.97% 79.94% -0.03% ========================================== Files 420 420 Lines 16362 16362 Branches 2275 2275 ========================================== - Hits 13085 13081 -4 - Misses 2439 2443 +4 Partials 838 838 ``` | [Flag](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2187/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2187/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) | `79.73% <ø> (-0.03%)` | :arrow_down: | | [unittests_timing](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2187/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) | `15.46% <ø> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#carryforward-flags-in-the-pull-request-comment) to find out more. [see 2 files with indirect coverage changes](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2187/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx)

[mossmaurice]

@elBoberido Up to you on whether you want to add your copyright.

[elBoberido]

@elBoberido Up to you on whether you want to add your copyright.

Na, not for clang-tidy fixes :)