eclipse-iceoryx / iceoryx

Eclipse iceoryx™ - true zero-copy inter-process-communication
https://iceoryx.io
Apache License 2.0
1.68k stars 393 forks source link

iox-#2167 Update FiFo #2205

Closed albtam closed 8 months ago

albtam commented 8 months ago

Pre-Review Checklist for the PR Author

  1. [x] Add a second reviewer for complex new features or larger refactorings
  2. [x] Code follows the coding style of CONTRIBUTING.md
  3. [x] Tests follow the best practice for testing
  4. [x] Changelog updated in the unreleased section including API breaking changes
  5. [x] Branch follows the naming format (iox-123-this-is-a-branch)
  6. [x] Commits messages are according to this guideline
  7. [x] Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  8. [x] Relevant issues are linked
  9. [x] Add sensible notes for the reviewer
  10. [x] All checks have passed (except task-list-completed)
  11. [x] All touched (C/C++) source code files from iceoryx_hoofs are added to ./clang-tidy-diff-scans.txt
  12. [x] Assign PR to reviewer

Notes for Reviewer

See discussion

Checklist for the PR Reviewer

Post-review Checklist for the PR Author

  1. [x] All open points are addressed and tracked via issues

References

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 79.79%. Comparing base (1979ead) to head (d0288de). Report is 35 commits behind head on master.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2205/graphs/tree.svg?width=650&height=150&src=pr&token=KWu8wdCc1S&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx)](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2205?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) ```diff @@ Coverage Diff @@ ## master #2205 +/- ## ======================================= Coverage 79.78% 79.79% ======================================= Files 420 420 Lines 16412 16413 +1 Branches 2288 2288 ======================================= + Hits 13095 13097 +2 Misses 2467 2467 + Partials 850 849 -1 ``` | [Flag](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2205/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2205/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) | `79.58% <100.00%> (+<0.01%)` | :arrow_up: | | [unittests_timing](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2205/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) | `15.41% <0.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2205?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) | Coverage Δ | | |---|---|---| | [...concurrent/buffer/include/iox/detail/spsc\_fifo.inl](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2205?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eF9ob29mcy9jb25jdXJyZW50L2J1ZmZlci9pbmNsdWRlL2lveC9kZXRhaWwvc3BzY19maWZvLmlubA==) | `100.00% <100.00%> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2205/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx)
albtam commented 8 months ago

@elBoberido I addressed your latest comments in https://github.com/eclipse-iceoryx/iceoryx/pull/2168 . Can you please review again?