eclipse-iceoryx / iceoryx

Eclipse iceoryx™ - true zero-copy inter-process-communication
https://iceoryx.io
Apache License 2.0
1.68k stars 393 forks source link

iox-#1755 Redirect printing in the platform layer to the logger #2222

Closed elBoberido closed 8 months ago

elBoberido commented 8 months ago

Pre-Review Checklist for the PR Author

  1. [x] Add a second reviewer for complex new features or larger refactorings
  2. [x] Code follows the coding style of CONTRIBUTING.md
  3. [x] Tests follow the best practice for testing
  4. [x] Changelog updated in the unreleased section including API breaking changes
  5. [x] Branch follows the naming format (iox-123-this-is-a-branch)
  6. [x] Commits messages are according to this guideline
  7. [x] Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  8. [x] Relevant issues are linked
  9. [x] Add sensible notes for the reviewer
  10. [x] All checks have passed (except task-list-completed)
  11. [x] All touched (C/C++) source code files from iceoryx_hoofs are added to ./clang-tidy-diff-scans.txt
  12. [x] Assign PR to reviewer

Notes for Reviewer

This PR redirects the output from the platform to the hoofs logger once the hoofs logger is initialized.

Checklist for the PR Reviewer

Post-review Checklist for the PR Author

  1. [x] All open points are addressed and tracked via issues

References

codecov[bot] commented 8 months ago

Codecov Report

Attention: Patch coverage is 58.24176% with 38 lines in your changes are missing coverage. Please review.

Project coverage is 78.51%. Comparing base (19184d4) to head (9a62ad5). Report is 11 commits behind head on master.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2222/graphs/tree.svg?width=650&height=150&src=pr&token=KWu8wdCc1S&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx)](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2222?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) ```diff @@ Coverage Diff @@ ## master #2222 +/- ## ========================================== - Coverage 78.62% 78.51% -0.12% ========================================== Files 429 431 +2 Lines 16538 16629 +91 Branches 2308 2333 +25 ========================================== + Hits 13003 13056 +53 - Misses 2682 2707 +25 - Partials 853 866 +13 ``` | [Flag](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2222/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2222/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) | `78.30% <58.24%> (-0.12%)` | :arrow_down: | | [unittests_timing](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2222/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) | `15.32% <9.89%> (-0.03%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2222?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) | Coverage Δ | | |---|---|---| | [.../include/iox/detail/log/building\_blocks/logger.inl](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2222?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eF9ob29mcy9yZXBvcnRpbmcvaW5jbHVkZS9pb3gvZGV0YWlsL2xvZy9idWlsZGluZ19ibG9ja3MvbG9nZ2VyLmlubA==) | `58.97% <100.00%> (+1.07%)` | :arrow_up: | | [...porting/include/iox/log/building\_blocks/logger.hpp](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2222?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eF9ob29mcy9yZXBvcnRpbmcvaW5jbHVkZS9pb3gvbG9nL2J1aWxkaW5nX2Jsb2Nrcy9sb2dnZXIuaHBw) | `100.00% <ø> (ø)` | | | [iceoryx\_hoofs/reporting/source/logging.cpp](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2222?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eF9ob29mcy9yZXBvcnRpbmcvc291cmNlL2xvZ2dpbmcuY3Bw) | `78.57% <78.57%> (ø)` | | | [iceoryx\_platform/generic/source/logging.cpp](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2222?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eF9wbGF0Zm9ybS9nZW5lcmljL3NvdXJjZS9sb2dnaW5nLmNwcA==) | `48.38% <48.38%> (ø)` | |