eclipse-iceoryx / iceoryx

Eclipse iceoryx™ - true zero-copy inter-process-communication
https://iceoryx.io
Apache License 2.0
1.68k stars 393 forks source link

iox-2253 Fix span assert #2255

Closed pbarone-latai closed 7 months ago

pbarone-latai commented 7 months ago

Notes for Reviewer

This PR addresses #iox-2253 and makes a few other opportunistic improvements

  1. Removes the "End" template on the begin/end constructor per elBoberido's suggestion
  2. Adds a number of missing unit test cases for iox::span (informed by coverage reports)

Pre-Review Checklist for the PR Author

  1. [x] Code follows the coding style of CONTRIBUTING.md
  2. [x] Tests follow the best practice for testing
  3. [x] Changelog updated in the unreleased section including API breaking changes
  4. [x] Branch follows the naming format (iox-123-this-is-a-branch)
  5. [x] Commits messages are according to this guideline
  6. [x] Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. [x] Relevant issues are linked
  8. [x] Add sensible notes for the reviewer
  9. [x] All checks have passed (except task-list-completed)
  10. [x] Assign PR to reviewer

Checklist for the PR Reviewer

Post-review Checklist for the PR Author

  1. [x] All open points are addressed and tracked via issues

References

- Closes #2253
elBoberido commented 7 months ago

The failure of the nightly job is not related to this changes. For some reason I can reproduce that failure also for commits from weeks ago. Merging this and looking into the clang-tidy issue on the nightly build.