eclipse-iceoryx / iceoryx

Eclipse iceoryx™ - true zero-copy inter-process-communication
https://iceoryx.io
Apache License 2.0
1.57k stars 373 forks source link

iox-#2266 Removed warning set but not used #2265

Closed ahcorde closed 2 months ago

ahcorde commented 2 months ago

Pre-Review Checklist for the PR Author

  1. [x] Add a second reviewer for complex new features or larger refactorings
  2. [x] Code follows the coding style of CONTRIBUTING.md
  3. [x] Tests follow the best practice for testing
  4. [x] Changelog updated in the unreleased section including API breaking changes
  5. [x] Branch follows the naming format (iox-123-this-is-a-branch)
  6. [x] Commits messages are according to this guideline
  7. [x] Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  8. [x] Relevant issues are linked
  9. [x] Add sensible notes for the reviewer
  10. [x] All checks have passed (except task-list-completed)
  11. [x] All touched (C/C++) source code files from iceoryx_hoofs are added to ./clang-tidy-diff-scans.txt
  12. [x] Assign PR to reviewer

Notes for Reviewer

Checklist for the PR Reviewer

Post-review Checklist for the PR Author

  1. [x] All open points are addressed and tracked via issues

References

elfenpiff commented 2 months ago

@ahcorde Thank you for the fix! Could you please adjust your commit message and add the prefix iox-#2266 (it links to the issue I created for your fix.)

You can do this by

git commit --amend
# add iox-#2266 in front of your commit message
git push -f

The background is that we are a project that also runs on a safety-critical system, and therefore, we need to trace every commit message to a GitHub issue.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.47%. Comparing base (c36b875) to head (13a38b5). Report is 5 commits behind head on release_2.0.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2265/graphs/tree.svg?width=650&height=150&src=pr&token=KWu8wdCc1S&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx)](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2265?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) ```diff @@ Coverage Diff @@ ## release_2.0 #2265 +/- ## =============================================== + Coverage 78.42% 78.47% +0.05% =============================================== Files 370 370 Lines 14220 14218 -2 Branches 2061 2061 =============================================== + Hits 11152 11158 +6 + Misses 2383 2377 -6 + Partials 685 683 -2 ``` | [Flag](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2265/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2265/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) | `77.71% <ø> (+0.05%)` | :arrow_up: | | [unittests_timing](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2265/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) | `15.12% <ø> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2265?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) | Coverage Δ | | |---|---|---| | [...posh/source/gateway/toml\_gateway\_config\_parser.cpp](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2265?src=pr&el=tree&filepath=iceoryx_posh%2Fsource%2Fgateway%2Ftoml_gateway_config_parser.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eF9wb3NoL3NvdXJjZS9nYXRld2F5L3RvbWxfZ2F0ZXdheV9jb25maWdfcGFyc2VyLmNwcA==) | `90.90% <ø> (-0.32%)` | :arrow_down: | ... and [4 files with indirect coverage changes](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2265/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx)
ahcorde commented 2 months ago

Done @elfenpiff