Closed elBoberido closed 2 months ago
@ximion if you compile with -DIOX_DEFAULT_RESOURCE_PREFIX=foo
you can create your own island with iceoryx applications without interference from ROS2 applications running with Cyclone DDS and iceoryx.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 78.12%. Comparing base (
e1c82d6
) to head (4be9a7b
).
@ximion if you compile with
-DIOX_DEFAULT_RESOURCE_PREFIX=foo
you can create your own island with iceoryx applications without interference from ROS2 applications running with Cyclone DDS and iceoryx.
Oh wow, this is super nice, thank you! I'll test it :-) One drawback is that this will make it hard for people to compile my app and ROS2 using Linux-distribution-provided iceoryx packages - I would basically have to vendor IOX, which is slightly inconvenient. But I guess a lot of values are compile-time constants in IOX for performance and to simplify memory management, and this will make it possible for bespoke deployments to run both tools at the same time, which is incredibly nice and removes a big potential obstacle for when we switched to iceoryx :-)
Thank you!
@ximion if you compile with
-DIOX_DEFAULT_RESOURCE_PREFIX=foo
you can create your own island with iceoryx applications without interference from ROS2 applications running with Cyclone DDS and iceoryx.Oh wow, this is super nice, thank you! I'll test it :-) One drawback is that this will make it hard for people to compile my app and ROS2 using Linux-distribution-provided iceoryx packages - I would basically have to vendor IOX, which is slightly inconvenient. But I guess a lot of values are compile-time constants in IOX for performance and to simplify memory management, and this will make it possible for bespoke deployments to run both tools at the same time, which is incredibly nice and removes a big potential obstacle for when we switched to iceoryx :-)
Thank you!
@ximion it shouldn't be too hard to make this a run time option but I'm lacking time at the moment. Patches are welcome :)
@ximion it shouldn't be too hard to make this a run time option but I'm lacking time at the moment. Patches are welcome :)
That looks doable! Once the journal review I'm working on is done I'll look into this :-)
Great. You can ping us in the gitter chat or open a new discussion in the repo. We could give you some hints to get you up to speed :)
Notes for Reviewer
This PR makes the resource prefix a compile time option
Pre-Review Checklist for the PR Author
iox-123-this-is-a-branch
)iox-#123 commit text
)task-list-completed
)Checklist for the PR Reviewer
iceoryx_hoofs
have been added to./clang-tidy-diff-scans.txt
Post-review Checklist for the PR Author
References