iox-#2274 Fix clang-tidy-18 warnings

[elBoberido]

Notes for Reviewer

To prevent issues with the upcoming Ubuntu 24.04 release which has clang-tidy-18, this PR fixes all the new warnings introduced between clang-tidy-15 and clang-tidy-18

Pre-Review Checklist for the PR Author

1. [x] Code follows the coding style of CONTRIBUTING.md
2. [x] Tests follow the best practice for testing
3. [x] Changelog updated in the unreleased section including API breaking changes
4. [x] Branch follows the naming format (iox-123-this-is-a-branch)
5. [x] Commits messages are according to this guideline
   • [x] Commit messages have the issue ID (iox-#123 commit text)
   • [x] Commit author matches Eclipse Contributor Agreement (and ECA is signed)
6. [x] Update the PR title
   • Follow the same conventions as for commit messages
   • Link to the relevant issue
7. [x] Relevant issues are linked
8. [x] Add sensible notes for the reviewer
9. [x] All checks have passed (except task-list-completed)
10. [x] Assign PR to reviewer

Checklist for the PR Reviewer

• [x] Consider a second reviewer for complex new features or larger refactorings
• [x] Commits are properly organized and messages are according to the guideline
• [x] Code according to our coding style and naming conventions
• [x] Unit tests have been written for new behavior
• [x] Public API changes are documented via doxygen
• [x] Copyright owner are updated in the changed files
• [x] All touched (C/C++) source code files from iceoryx_hoofs have been added to ./clang-tidy-diff-scans.txt
• [x] PR title describes the changes

Post-review Checklist for the PR Author

1. [x] All open points are addressed and tracked via issues

References

• Closes #2274

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 34.28571% with 23 lines in your changes are missing coverage. Please review.

Project coverage is 78.06%. Comparing base (e880982) to head (b9ab7ee).

Additional details and impacted files

[](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2275?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) ```diff @@ Coverage Diff @@ ## main #2275 +/- ## ========================================== - Coverage 78.12% 78.06% -0.06% ========================================== Files 432 432 Lines 15898 15912 +14 Branches 2297 2303 +6 ========================================== + Hits 12420 12422 +2 - Misses 2631 2644 +13 + Partials 847 846 -1 ``` | [Flag](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2275/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2275/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) | `77.89% <34.28%> (-0.06%)` | :arrow_down: | | [unittests_timing](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2275/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) | `14.95% <8.57%> (-0.02%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2275?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) | Coverage Δ | | |---|---|---| | [iceoryx\_hoofs/buffer/include/iox/detail/stack.inl](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2275?src=pr&el=tree&filepath=iceoryx_hoofs%2Fbuffer%2Finclude%2Fiox%2Fdetail%2Fstack.inl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eF9ob29mcy9idWZmZXIvaW5jbHVkZS9pb3gvZGV0YWlsL3N0YWNrLmlubA==) | `94.02% <ø> (ø)` | | | [...detail/mpmc\_lockfree\_queue/mpmc\_lockfree\_queue.inl](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2275?src=pr&el=tree&filepath=iceoryx_hoofs%2Fconcurrent%2Fbuffer%2Finclude%2Fiox%2Fdetail%2Fmpmc_lockfree_queue%2Fmpmc_lockfree_queue.inl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eF9ob29mcy9jb25jdXJyZW50L2J1ZmZlci9pbmNsdWRlL2lveC9kZXRhaWwvbXBtY19sb2NrZnJlZV9xdWV1ZS9tcG1jX2xvY2tmcmVlX3F1ZXVlLmlubA==) | `98.24% <ø> (ø)` | | | [...\_lockfree\_queue/mpmc\_resizeable\_lockfree\_queue.inl](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2275?src=pr&el=tree&filepath=iceoryx_hoofs%2Fconcurrent%2Fbuffer%2Finclude%2Fiox%2Fdetail%2Fmpmc_lockfree_queue%2Fmpmc_resizeable_lockfree_queue.inl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eF9ob29mcy9jb25jdXJyZW50L2J1ZmZlci9pbmNsdWRlL2lveC9kZXRhaWwvbXBtY19sb2NrZnJlZV9xdWV1ZS9tcG1jX3Jlc2l6ZWFibGVfbG9ja2ZyZWVfcXVldWUuaW5s) | `90.41% <100.00%> (ø)` | | | [...oofs/container/include/iox/detail/forward\_list.inl](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2275?src=pr&el=tree&filepath=iceoryx_hoofs%2Fcontainer%2Finclude%2Fiox%2Fdetail%2Fforward_list.inl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eF9ob29mcy9jb250YWluZXIvaW5jbHVkZS9pb3gvZGV0YWlsL2ZvcndhcmRfbGlzdC5pbmw=) | `91.28% <100.00%> (ø)` | | | [...ceoryx\_hoofs/container/include/iox/detail/list.inl](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2275?src=pr&el=tree&filepath=iceoryx_hoofs%2Fcontainer%2Finclude%2Fiox%2Fdetail%2Flist.inl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eF9ob29mcy9jb250YWluZXIvaW5jbHVkZS9pb3gvZGV0YWlsL2xpc3QuaW5s) | `91.23% <ø> (ø)` | | | [...oryx\_hoofs/container/include/iox/detail/vector.inl](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2275?src=pr&el=tree&filepath=iceoryx_hoofs%2Fcontainer%2Finclude%2Fiox%2Fdetail%2Fvector.inl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eF9ob29mcy9jb250YWluZXIvaW5jbHVkZS9pb3gvZGV0YWlsL3ZlY3Rvci5pbmw=) | `96.31% <ø> (ø)` | | | [...container/include/iox/fixed\_position\_container.hpp](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2275?src=pr&el=tree&filepath=iceoryx_hoofs%2Fcontainer%2Finclude%2Fiox%2Ffixed_position_container.hpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eF9ob29mcy9jb250YWluZXIvaW5jbHVkZS9pb3gvZml4ZWRfcG9zaXRpb25fY29udGFpbmVyLmhwcA==) | `100.00% <ø> (ø)` | | | [...\_hoofs/design/include/iox/move\_and\_copy\_helper.hpp](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2275?src=pr&el=tree&filepath=iceoryx_hoofs%2Fdesign%2Finclude%2Fiox%2Fmove_and_copy_helper.hpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eF9ob29mcy9kZXNpZ24vaW5jbHVkZS9pb3gvbW92ZV9hbmRfY29weV9oZWxwZXIuaHBw) | `100.00% <ø> (ø)` | | | [...eoryx\_hoofs/filesystem/include/iox/file\_reader.hpp](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2275?src=pr&el=tree&filepath=iceoryx_hoofs%2Ffilesystem%2Finclude%2Fiox%2Ffile_reader.hpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eF9ob29mcy9maWxlc3lzdGVtL2luY2x1ZGUvaW94L2ZpbGVfcmVhZGVyLmhwcA==) | `100.00% <ø> (ø)` | | | [...ceoryx\_hoofs/filesystem/include/iox/filesystem.hpp](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2275?src=pr&el=tree&filepath=iceoryx_hoofs%2Ffilesystem%2Finclude%2Fiox%2Ffilesystem.hpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eF9ob29mcy9maWxlc3lzdGVtL2luY2x1ZGUvaW94L2ZpbGVzeXN0ZW0uaHBw) | `100.00% <ø> (ø)` | | | ... and [46 more](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2275?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2275/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx)