eclipse-iceoryx / iceoryx

Eclipse iceoryx™ - true zero-copy inter-process-communication
https://iceoryx.io
Apache License 2.0
1.65k stars 384 forks source link

iox-#2282 Prepare v2.0.6 release #2283

Closed elBoberido closed 5 months ago

elBoberido commented 5 months ago

Notes for Reviewer

Pre-Review Checklist for the PR Author

  1. [x] Code follows the coding style of CONTRIBUTING.md
  2. [x] Tests follow the best practice for testing
  3. [x] Changelog updated in the unreleased section including API breaking changes
  4. [x] Branch follows the naming format (iox-123-this-is-a-branch)
  5. [x] Commits messages are according to this guideline
  6. [x] Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. [x] Relevant issues are linked
  8. [x] Add sensible notes for the reviewer
  9. [x] All checks have passed (except task-list-completed)
  10. [x] Assign PR to reviewer

Checklist for the PR Reviewer

Post-review Checklist for the PR Author

  1. [x] All open points are addressed and tracked via issues

References

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 78.47%. Comparing base (13a38b5) to head (625b2d0). Report is 5 commits behind head on release_2.0.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2283/graphs/tree.svg?width=650&height=150&src=pr&token=KWu8wdCc1S&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx)](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2283?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) ```diff @@ Coverage Diff @@ ## release_2.0 #2283 +/- ## =============================================== - Coverage 78.47% 78.47% -0.01% =============================================== Files 370 370 Lines 14218 14217 -1 Branches 2061 2060 -1 =============================================== - Hits 11158 11157 -1 Misses 2377 2377 Partials 683 683 ``` | [Flag](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2283/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2283/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) | `77.70% <0.00%> (-0.01%)` | :arrow_down: | | [unittests_timing](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2283/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) | `15.12% <0.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2283?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) | Coverage Δ | | |---|---|---| | [iceoryx\_dds/source/gateway/main.cpp](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2283?src=pr&el=tree&filepath=iceoryx_dds%2Fsource%2Fgateway%2Fmain.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eF9kZHMvc291cmNlL2dhdGV3YXkvbWFpbi5jcHA=) | `0.00% <0.00%> (ø)` | | ... and [4 files with indirect coverage changes](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2283/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx)
elBoberido commented 5 months ago

ROS2 CI

elBoberido commented 5 months ago

@clalancette the aarch64 builds are marked as unstable. I'm quite sure it is not related to the changes of this PR and would create the release nevertheless

elBoberido commented 5 months ago

@mossmaurice it seems the approval was not discarded after updating the release date in the release notes

Re-triggered the ROS2 CI

elBoberido commented 5 months ago

@clalancette all the failed tests on aarch64 yesterday had this error message

mimick: Initialization error: could not find definitions for vital function(s): 'abort' 'vfprintf'

This is not related in any way to iceoryx and if the current run will have the same failures I'll merge this branch and create the release

clalancette commented 5 months ago

This is not related in any way to iceoryx and if the current run will have the same failures I'll merge this branch and create the release

Yes, that's correct. That's a known issue that we are tracking separately: https://github.com/ros2/Mimick/issues/35