eclipse-iceoryx / iceoryx

Eclipse iceoryx™ - true zero-copy inter-process-communication
https://iceoryx.io
Apache License 2.0
1.69k stars 393 forks source link

iox-#2289 Add 'iox' prefix to all 'unistd.hpp' entities #2290

Closed elBoberido closed 6 months ago

elBoberido commented 6 months ago

Notes for Reviewer

Pre-Review Checklist for the PR Author

  1. [x] Code follows the coding style of CONTRIBUTING.md
  2. [x] Tests follow the best practice for testing
  3. [x] Changelog updated in the unreleased section including API breaking changes
  4. [x] Branch follows the naming format (iox-123-this-is-a-branch)
  5. [x] Commits messages are according to this guideline
  6. [x] Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. [x] Relevant issues are linked
  8. [x] Add sensible notes for the reviewer
  9. [x] All checks have passed (except task-list-completed)
  10. [x] Assign PR to reviewer

Checklist for the PR Reviewer

Post-review Checklist for the PR Author

  1. [x] All open points are addressed and tracked via issues

References

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 94.28571% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 78.07%. Comparing base (f6dc4e1) to head (aa6149f).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2290/graphs/tree.svg?width=650&height=150&src=pr&token=KWu8wdCc1S&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx)](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2290?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) ```diff @@ Coverage Diff @@ ## main #2290 +/- ## ========================================== + Coverage 78.06% 78.07% +0.01% ========================================== Files 432 432 Lines 15912 15920 +8 Branches 2303 2303 ========================================== + Hits 12421 12429 +8 Misses 2644 2644 Partials 847 847 ``` | [Flag](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2290/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2290/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) | `77.89% <94.28%> (+0.01%)` | :arrow_up: | | [unittests_timing](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2290/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) | `14.95% <0.00%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2290?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) | Coverage Δ | | |---|---|---| | [iceoryx\_hoofs/posix/auth/source/posix\_user.cpp](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2290?src=pr&el=tree&filepath=iceoryx_hoofs%2Fposix%2Fauth%2Fsource%2Fposix_user.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eF9ob29mcy9wb3NpeC9hdXRoL3NvdXJjZS9wb3NpeF91c2VyLmNwcA==) | `76.78% <100.00%> (ø)` | | | [iceoryx\_hoofs/posix/filesystem/source/file.cpp](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2290?src=pr&el=tree&filepath=iceoryx_hoofs%2Fposix%2Ffilesystem%2Fsource%2Ffile.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eF9ob29mcy9wb3NpeC9maWxlc3lzdGVtL3NvdXJjZS9maWxlLmNwcA==) | `32.28% <100.00%> (ø)` | | | [...ryx\_hoofs/posix/ipc/source/posix\_shared\_memory.cpp](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2290?src=pr&el=tree&filepath=iceoryx_hoofs%2Fposix%2Fipc%2Fsource%2Fposix_shared_memory.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eF9ob29mcy9wb3NpeC9pcGMvc291cmNlL3Bvc2l4X3NoYXJlZF9tZW1vcnkuY3Bw) | `64.37% <100.00%> (ø)` | | | [...oofs/posix/utility/source/system\_configuration.cpp](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2290?src=pr&el=tree&filepath=iceoryx_hoofs%2Fposix%2Futility%2Fsource%2Fsystem_configuration.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eF9ob29mcy9wb3NpeC91dGlsaXR5L3NvdXJjZS9zeXN0ZW1fY29uZmlndXJhdGlvbi5jcHA=) | `77.77% <100.00%> (ø)` | | | [iceoryx\_platform/linux/source/grp.cpp](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2290?src=pr&el=tree&filepath=iceoryx_platform%2Flinux%2Fsource%2Fgrp.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eF9wbGF0Zm9ybS9saW51eC9zb3VyY2UvZ3JwLmNwcA==) | `100.00% <100.00%> (ø)` | | | [iceoryx\_platform/linux/source/unistd.cpp](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2290?src=pr&el=tree&filepath=iceoryx_platform%2Flinux%2Fsource%2Funistd.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eF9wbGF0Zm9ybS9saW51eC9zb3VyY2UvdW5pc3RkLmNwcA==) | `91.66% <100.00%> (+4.16%)` | :arrow_up: | | [...e/iceoryx\_posh/internal/popo/notification\_info.inl](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2290?src=pr&el=tree&filepath=iceoryx_posh%2Finclude%2Ficeoryx_posh%2Finternal%2Fpopo%2Fnotification_info.inl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eF9wb3NoL2luY2x1ZGUvaWNlb3J5eF9wb3NoL2ludGVybmFsL3BvcG8vbm90aWZpY2F0aW9uX2luZm8uaW5s) | `100.00% <ø> (ø)` | | | [...posh/include/iceoryx\_posh/internal/roudi/roudi.hpp](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2290?src=pr&el=tree&filepath=iceoryx_posh%2Finclude%2Ficeoryx_posh%2Finternal%2Froudi%2Froudi.hpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eF9wb3NoL2luY2x1ZGUvaWNlb3J5eF9wb3NoL2ludGVybmFsL3JvdWRpL3JvdWRpLmhwcA==) | `60.00% <ø> (ø)` | | | [iceoryx\_posh/source/roudi/roudi.cpp](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2290?src=pr&el=tree&filepath=iceoryx_posh%2Fsource%2Froudi%2Froudi.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eF9wb3NoL3NvdXJjZS9yb3VkaS9yb3VkaS5jcHA=) | `64.91% <100.00%> (ø)` | | | [iceoryx\_hoofs/posix/auth/source/posix\_group.cpp](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2290?src=pr&el=tree&filepath=iceoryx_hoofs%2Fposix%2Fauth%2Fsource%2Fposix_group.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eF9ob29mcy9wb3NpeC9hdXRoL3NvdXJjZS9wb3NpeF9ncm91cC5jcHA=) | `79.41% <85.71%> (ø)` | | | ... and [1 more](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2290?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) | |