Closed clalancette closed 3 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 78.47%. Comparing base (
434ee45
) to head (a4a1157
). Report is 3 commits behind head on release_2.0.
Once again, thanks for fixing the warnings. Could you please add iox-#210
to the commit message ... and push ;)
Once again, thanks for fixing the warnings. Could you please add
iox-#210
to the commit message ... and push ;)
Sorry for the delay here. I've now done that.
When building the
iceoryx_hoofs
package from therelease_2.0
branch in Release mode (-DCMAKE_BUILD_TYPE=Release
), with gcc 13, we get warnings like the following:This change avoids the warning by just always assigning a zero. However, this isn't really a serious attempt at a fix, but more of a way to start a discussion. I noticed that the
main
branch compiles without warnings, but does not have this zero in place. That said, I do not understand the mechanism that is being used there, so I'm having trouble tracking down the difference between themain
branch and this one. Any thoughts on the "correct" way to fix this?(skipping the rest of the checklist for now until we decide what to do here)
Notes for Reviewer
Pre-Review Checklist for the PR Author
iox-123-this-is-a-branch
)iox-#123 commit text
)task-list-completed
)Checklist for the PR Reviewer
iceoryx_hoofs
have been added to./clang-tidy-diff-scans.txt
Post-review Checklist for the PR Author
References