eclipse-iceoryx / iceoryx

Eclipse iceoryx™ - true zero-copy inter-process-communication
https://iceoryx.io
Apache License 2.0
1.65k stars 384 forks source link

iox-#2299 Add port counts to introspection client #2300

Closed tobiasstarkwayve closed 3 months ago

tobiasstarkwayve commented 3 months ago

Notes for Reviewer

This PR adds the number of ports to the introspection client display. This makes it easier to get a quick overview over the number of active ports if there are too many to count by hand.

Pre-Review Checklist for the PR Author

  1. [x] Code follows the coding style of CONTRIBUTING.md
  2. [x] Tests follow the best practice for testing
  3. [x] Changelog updated in the unreleased section including API breaking changes
  4. [x] Branch follows the naming format (iox-123-this-is-a-branch)
  5. [x] Commits messages are according to this guideline
  6. [x] Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. [x] Relevant issues are linked
  8. [x] Add sensible notes for the reviewer
  9. [x] All checks have passed (except task-list-completed)
  10. [x] Assign PR to reviewer

Checklist for the PR Reviewer

Post-review Checklist for the PR Author

  1. [x] All open points are addressed and tracked via issues

References

elfenpiff commented 3 months ago

@tobiasstarkwayve Thanks for the contribution. Everything seems to be in order, but the clang-format preflight check complains. In the root dir of the repo, there is already a .clang-format file. Could you please format the file with your IDE? It should work out of the box with any clang-format extension.

You must also sign the Eclipse contribution agreement (https://www.eclipse.org/legal/ECA.php) using the email address you used for your commit message.

As soon as this is done, we can merge the PR.

tobiasstarkwayve commented 3 months ago

@tobiasstarkwayve Thanks for the contribution. Everything seems to be in order, but the clang-format preflight check complains. In the root dir of the repo, there is already a .clang-format file. Could you please format the file with your IDE? It should work out of the box with any clang-format extension.

You must also sign the Eclipse contribution agreement (https://www.eclipse.org/legal/ECA.php) using the email address you used for your commit message.

As soon as this is done, we can merge the PR.

Done. I actually signed the ECA yesterday already, but I think it took some time to propagate the information (or pushing a new commit forced it to re-evaluate). Either way, the box is green now :-)