Closed tobiasstarkwayve closed 3 months ago
@tobiasstarkwayve Thanks for the contribution. Everything seems to be in order, but the clang-format preflight check complains. In the root dir of the repo, there is already a .clang-format
file. Could you please format the file with your IDE? It should work out of the box with any clang-format extension.
You must also sign the Eclipse contribution agreement (https://www.eclipse.org/legal/ECA.php) using the email address you used for your commit message.
As soon as this is done, we can merge the PR.
@tobiasstarkwayve Thanks for the contribution. Everything seems to be in order, but the clang-format preflight check complains. In the root dir of the repo, there is already a
.clang-format
file. Could you please format the file with your IDE? It should work out of the box with any clang-format extension.You must also sign the Eclipse contribution agreement (https://www.eclipse.org/legal/ECA.php) using the email address you used for your commit message.
As soon as this is done, we can merge the PR.
Done. I actually signed the ECA yesterday already, but I think it took some time to propagate the information (or pushing a new commit forced it to re-evaluate). Either way, the box is green now :-)
Notes for Reviewer
This PR adds the number of ports to the introspection client display. This makes it easier to get a quick overview over the number of active ports if there are too many to count by hand.
Pre-Review Checklist for the PR Author
iox-123-this-is-a-branch
)iox-#123 commit text
)task-list-completed
)Checklist for the PR Reviewer
iceoryx_hoofs
have been added to./clang-tidy-diff-scans.txt
Post-review Checklist for the PR Author
References