Closed adityakarumanchi closed 2 days ago
@adityakarumanchi thanks for taking the effort to contribute to iceoryx. Unfortunately this is something we want to do after the 3.0 release. Since this touches quite a lot of files and makes it harder for downstream to apply patches, we would like to check whether other formatting rules should also be changed in order to have this kind of change only once. We should have made this more clear than just adding it to the v4.0 project.
Is there anything else you are interested in from the open issues?
@adityakarumanchi thanks for taking the effort to contribute to iceoryx. Unfortunately this is something we want to do after the 3.0 release. Since this touches quite a lot of files and makes it harder for downstream to apply patches, we would like to check whether other formatting rules should also be changed in order to have this kind of change only once. We should have made this more clear than just adding it to the v4.0 project.
Is there anything else you are interested in from the open issues?
No worries. I'll take another look at the open issues. Should I close this PR, or will that happen automatically anyway?
@adityakarumanchi I'll close it and update the issue accordingly
This PR modifies the clang-format configuration to automatically add spaces around brace-initialization. It also modifies all relevant files as per this new clang-format config.
Notes for Reviewer
Pre-Review Checklist for the PR Author
iox-123-this-is-a-branch
)iox-#123 commit text
)task-list-completed
)Checklist for the PR Reviewer
iceoryx_hoofs
have been added to./clang-tidy-diff-scans.txt
Post-review Checklist for the PR Author
References