eclipse-iceoryx / iceoryx

Eclipse iceoryx™ - true zero-copy inter-process-communication
https://iceoryx.io
Apache License 2.0
1.57k stars 373 forks source link

iox-#1611 Change clang-format flag, commit fmt changes #2310

Closed adityakarumanchi closed 2 days ago

adityakarumanchi commented 3 days ago

This PR modifies the clang-format configuration to automatically add spaces around brace-initialization. It also modifies all relevant files as per this new clang-format config.

Notes for Reviewer

Pre-Review Checklist for the PR Author

  1. [x] Code follows the coding style of CONTRIBUTING.md -> No new code added
  2. [x] Tests follow the best practice for testing -> No new tests added
  3. [x] Changelog updated in the unreleased section including API breaking changes -> No code changes
  4. [x] Branch follows the naming format (iox-123-this-is-a-branch)
  5. [x] Commits messages are according to this guideline
  6. [x] Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. [x] Relevant issues are linked
  8. [ ] Add sensible notes for the reviewer
  9. [ ] All checks have passed (except task-list-completed)
  10. [ ] Assign PR to reviewer

Checklist for the PR Reviewer

Post-review Checklist for the PR Author

  1. [ ] All open points are addressed and tracked via issues

References

elBoberido commented 2 days ago

@adityakarumanchi thanks for taking the effort to contribute to iceoryx. Unfortunately this is something we want to do after the 3.0 release. Since this touches quite a lot of files and makes it harder for downstream to apply patches, we would like to check whether other formatting rules should also be changed in order to have this kind of change only once. We should have made this more clear than just adding it to the v4.0 project.

Is there anything else you are interested in from the open issues?

adityakarumanchi commented 2 days ago

@adityakarumanchi thanks for taking the effort to contribute to iceoryx. Unfortunately this is something we want to do after the 3.0 release. Since this touches quite a lot of files and makes it harder for downstream to apply patches, we would like to check whether other formatting rules should also be changed in order to have this kind of change only once. We should have made this more clear than just adding it to the v4.0 project.

Is there anything else you are interested in from the open issues?

No worries. I'll take another look at the open issues. Should I close this PR, or will that happen automatically anyway?

elBoberido commented 2 days ago

@adityakarumanchi I'll close it and update the issue accordingly