eclipse-iceoryx / iceoryx

Eclipse iceoryx™ - true zero-copy inter-process-communication
https://iceoryx.io
Apache License 2.0
1.69k stars 393 forks source link

iox-#2329 Use iox::concurrent::Atomic #2332

Closed elBoberido closed 3 months ago

elBoberido commented 3 months ago

Notes for Reviewer

This PR replaces std::atomic with iox::concurrent::Atomic and adds a shell script to check for invalid use of std::atomic

Pre-Review Checklist for the PR Author

  1. [x] Code follows the coding style of CONTRIBUTING.md
  2. [x] Tests follow the best practice for testing
  3. [x] Changelog updated in the unreleased section including API breaking changes
  4. [x] Branch follows the naming format (iox-123-this-is-a-branch)
  5. [x] Commits messages are according to this guideline
  6. [x] Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. [x] Relevant issues are linked
  8. [x] Add sensible notes for the reviewer
  9. [x] All checks have passed (except task-list-completed)
  10. [x] Assign PR to reviewer

Checklist for the PR Reviewer

Post-review Checklist for the PR Author

  1. [x] All open points are addressed and tracked via issues

References

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.22%. Comparing base (8a2a18f) to head (bf4e66a). Report is 5 commits behind head on main.

Files Patch % Lines
iceoryx_posh/source/runtime/posh_runtime.cpp 0.00% 2 Missing :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2332/graphs/tree.svg?width=650&height=150&src=pr&token=KWu8wdCc1S&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx)](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2332?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) ```diff @@ Coverage Diff @@ ## main #2332 +/- ## ======================================= Coverage 78.21% 78.22% ======================================= Files 433 433 Lines 16028 16034 +6 Branches 2303 2302 -1 ======================================= + Hits 12537 12543 +6 Misses 2644 2644 Partials 847 847 ``` | [Flag](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2332/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2332/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) | `78.05% <50.00%> (+<0.01%)` | :arrow_up: | | [unittests_timing](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2332/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) | `15.04% <0.00%> (+0.18%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2332?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) | Coverage Δ | | |---|---|---| | [...ncurrent/buffer/include/iox/detail/mpmc\_loffli.hpp](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2332?src=pr&el=tree&filepath=iceoryx_hoofs%2Fconcurrent%2Fbuffer%2Finclude%2Fiox%2Fdetail%2Fmpmc_loffli.hpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eF9ob29mcy9jb25jdXJyZW50L2J1ZmZlci9pbmNsdWRlL2lveC9kZXRhaWwvbXBtY19sb2ZmbGkuaHBw) | `100.00% <ø> (ø)` | | | [...lude/iox/detail/mpmc\_resizeable\_lockfree\_queue.hpp](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2332?src=pr&el=tree&filepath=iceoryx_hoofs%2Fconcurrent%2Fbuffer%2Finclude%2Fiox%2Fdetail%2Fmpmc_resizeable_lockfree_queue.hpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eF9ob29mcy9jb25jdXJyZW50L2J1ZmZlci9pbmNsdWRlL2lveC9kZXRhaWwvbXBtY19yZXNpemVhYmxlX2xvY2tmcmVlX3F1ZXVlLmhwcA==) | `100.00% <ø> (ø)` | | | [...concurrent/buffer/include/iox/detail/spsc\_sofi.hpp](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2332?src=pr&el=tree&filepath=iceoryx_hoofs%2Fconcurrent%2Fbuffer%2Finclude%2Fiox%2Fdetail%2Fspsc_sofi.hpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eF9ob29mcy9jb25jdXJyZW50L2J1ZmZlci9pbmNsdWRlL2lveC9kZXRhaWwvc3BzY19zb2ZpLmhwcA==) | `100.00% <ø> (ø)` | | | [...ryx\_hoofs/concurrent/buffer/source/mpmc\_loffli.cpp](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2332?src=pr&el=tree&filepath=iceoryx_hoofs%2Fconcurrent%2Fbuffer%2Fsource%2Fmpmc_loffli.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eF9ob29mcy9jb25jdXJyZW50L2J1ZmZlci9zb3VyY2UvbXBtY19sb2ZmbGkuY3Bw) | `87.09% <ø> (-0.41%)` | :arrow_down: | | [.../design/include/iox/detail/polymorphic\_handler.inl](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2332?src=pr&el=tree&filepath=iceoryx_hoofs%2Fdesign%2Finclude%2Fiox%2Fdetail%2Fpolymorphic_handler.inl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eF9ob29mcy9kZXNpZ24vaW5jbHVkZS9pb3gvZGV0YWlsL3BvbHltb3JwaGljX2hhbmRsZXIuaW5s) | `87.17% <ø> (ø)` | | | [...esign/include/iox/detail/static\_lifetime\_guard.inl](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2332?src=pr&el=tree&filepath=iceoryx_hoofs%2Fdesign%2Finclude%2Fiox%2Fdetail%2Fstatic_lifetime_guard.inl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eF9ob29mcy9kZXNpZ24vaW5jbHVkZS9pb3gvZGV0YWlsL3N0YXRpY19saWZldGltZV9ndWFyZC5pbmw=) | `94.28% <ø> (+0.73%)` | :arrow_up: | | [iceoryx\_hoofs/posix/ipc/include/iox/named\_pipe.hpp](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2332?src=pr&el=tree&filepath=iceoryx_hoofs%2Fposix%2Fipc%2Finclude%2Fiox%2Fnamed_pipe.hpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eF9ob29mcy9wb3NpeC9pcGMvaW5jbHVkZS9pb3gvbmFtZWRfcGlwZS5ocHA=) | `100.00% <ø> (ø)` | | | [...yx\_hoofs/posix/sync/include/iox/signal\_watcher.hpp](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2332?src=pr&el=tree&filepath=iceoryx_hoofs%2Fposix%2Fsync%2Finclude%2Fiox%2Fsignal_watcher.hpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eF9ob29mcy9wb3NpeC9zeW5jL2luY2x1ZGUvaW94L3NpZ25hbF93YXRjaGVyLmhwcA==) | `100.00% <ø> (ø)` | | | [iceoryx\_hoofs/posix/sync/include/iox/thread.hpp](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2332?src=pr&el=tree&filepath=iceoryx_hoofs%2Fposix%2Fsync%2Finclude%2Fiox%2Fthread.hpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eF9ob29mcy9wb3NpeC9zeW5jL2luY2x1ZGUvaW94L3RocmVhZC5ocHA=) | `100.00% <ø> (ø)` | | | [.../include/iox/detail/log/building\_blocks/logger.inl](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2332?src=pr&el=tree&filepath=iceoryx_hoofs%2Freporting%2Finclude%2Fiox%2Fdetail%2Flog%2Fbuilding_blocks%2Flogger.inl&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eF9ob29mcy9yZXBvcnRpbmcvaW5jbHVkZS9pb3gvZGV0YWlsL2xvZy9idWlsZGluZ19ibG9ja3MvbG9nZ2VyLmlubA==) | `58.97% <ø> (ø)` | | | ... and [17 more](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2332?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2332/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx)