eclipse-iceoryx / iceoryx

Eclipse iceoryx™ - true zero-copy inter-process-communication
https://iceoryx.io
Apache License 2.0
1.69k stars 393 forks source link

iox-#1176 Make ACL support optional #2359

Closed elBoberido closed 1 month ago

elBoberido commented 1 month ago

Notes for Reviewer

This PR makes the adds a compile time option to disable the ACL feature, even on supported OSes. This is useful in cases WSL (Windows Subsystem for Linux) which does not support ACLs but is identified as Linux.

The PR also adds the feature flag for bazel builds.

The feature is deactivated by using the same dummy implementation like it is done on platforms that do not support ACLs.

To reduce code duplication. The platform files for ACSs are also refactored with the new C++17 approach to conditionally include headers.

Furthermore, it fixes a cache issue with the Cirrus CI and add a link to the link checker ignore list due to repeatedly Too Many Requests errors in the CI.

Pre-Review Checklist for the PR Author

  1. [x] Code follows the coding style of CONTRIBUTING.md
  2. [x] Tests follow the best practice for testing
  3. [x] Changelog updated in the unreleased section including API breaking changes
  4. [x] Branch follows the naming format (iox-123-this-is-a-branch)
  5. [x] Commits messages are according to this guideline
  6. [x] Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. [x] Relevant issues are linked
  8. [x] Add sensible notes for the reviewer
  9. [x] All checks have passed (except task-list-completed)
  10. [x] Assign PR to reviewer

Checklist for the PR Reviewer

Post-review Checklist for the PR Author

  1. [x] All open points are addressed and tracked via issues

References

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 82.35294% with 6 lines in your changes missing coverage. Please review.

Project coverage is 78.32%. Comparing base (89d73e0) to head (4356597). Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
iceoryx_platform/generic/source/acl_feature_on.cpp 75.00% 6 Missing :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2359/graphs/tree.svg?width=650&height=150&src=pr&token=KWu8wdCc1S&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx)](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2359?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) ```diff @@ Coverage Diff @@ ## main #2359 +/- ## ======================================= Coverage 78.32% 78.32% ======================================= Files 439 440 +1 Lines 16162 16186 +24 Branches 2314 2314 ======================================= + Hits 12659 12678 +19 - Misses 2652 2658 +6 + Partials 851 850 -1 ``` | [Flag](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2359/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2359/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) | `78.15% <82.35%> (+<0.01%)` | :arrow_up: | | [unittests_timing](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2359/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) | `15.05% <0.00%> (-0.03%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2359?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) | Coverage Δ | | |---|---|---| | [...ceoryx\_hoofs/posix/filesystem/source/posix\_acl.cpp](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2359?src=pr&el=tree&filepath=iceoryx_hoofs%2Fposix%2Ffilesystem%2Fsource%2Fposix_acl.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eF9ob29mcy9wb3NpeC9maWxlc3lzdGVtL3NvdXJjZS9wb3NpeF9hY2wuY3Bw) | `65.54% <100.00%> (ø)` | | | [iceoryx\_platform/generic/source/acl\_feature\_on.cpp](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2359?src=pr&el=tree&filepath=iceoryx_platform%2Fgeneric%2Fsource%2Facl_feature_on.cpp&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eF9wbGF0Zm9ybS9nZW5lcmljL3NvdXJjZS9hY2xfZmVhdHVyZV9vbi5jcHA=) | `75.00% <75.00%> (ø)` | | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2359/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx)