Closed elBoberido closed 1 month ago
Attention: Patch coverage is 82.35294%
with 6 lines
in your changes missing coverage. Please review.
Project coverage is 78.32%. Comparing base (
89d73e0
) to head (4356597
). Report is 11 commits behind head on main.
Files with missing lines | Patch % | Lines |
---|---|---|
iceoryx_platform/generic/source/acl_feature_on.cpp | 75.00% | 6 Missing :warning: |
Notes for Reviewer
This PR makes the adds a compile time option to disable the ACL feature, even on supported OSes. This is useful in cases WSL (Windows Subsystem for Linux) which does not support ACLs but is identified as Linux.
The PR also adds the feature flag for bazel builds.
The feature is deactivated by using the same dummy implementation like it is done on platforms that do not support ACLs.
To reduce code duplication. The platform files for ACSs are also refactored with the new C++17 approach to conditionally include headers.
Furthermore, it fixes a cache issue with the Cirrus CI and add a link to the link checker ignore list due to repeatedly
Too Many Requests
errors in the CI.Pre-Review Checklist for the PR Author
iox-123-this-is-a-branch
)iox-#123 commit text
)task-list-completed
)Checklist for the PR Reviewer
iceoryx_hoofs
have been added to./clang-tidy-diff-scans.txt
Post-review Checklist for the PR Author
References