Closed lalten closed 3 weeks ago
@lalten Thanks for the contribution. Since we are an open source project under the eclipse foundation you need to sign the ECA: https://www.eclipse.org/legal/eca/
We are targeting mission-critical systems and this requires that every change in the repo must be connected to an issue. So could you please create an issue.
Also every commit must have the prefix iox-#???
where ??? is the issue number.
@elfenpiff please have another look.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 78.71%. Comparing base (
fc86354
) to head (3978c63
). Report is 3 commits behind head on main.
@lalten Looks good. I created this issue #2364 for you. Could you please adjust your commit message so that the prefix is iox-#2364
- then we can merge this PR.
@elfenpiff anything left to do on my side for this PR?
@lalten can you please rebase? We deactivated the Cirrus CI on main since we ran out of credits for the open source project.
@lalten thanks for your contribution and sorry letting you wait so long with the merge :)
Notes for Reviewer
Currently if you want to depend on Iceoryx as a Bzlmod bazel_dep you have to do something like
It would be nice to fix that typo.
I'll send some follow up PRs to contribute patches that make depending on the module via Bzlmod actually work.
Pre-Review Checklist for the PR Author
iox-123-this-is-a-branch
)iox-#123 commit text
)task-list-completed
)Checklist for the PR Reviewer
iceoryx_hoofs
have been added to./clang-tidy-diff-scans.txt
Post-review Checklist for the PR Author
References