eclipse-iceoryx / iceoryx

Eclipse iceoryx™ - true zero-copy inter-process-communication
https://iceoryx.io
Apache License 2.0
1.69k stars 393 forks source link

iox-#2364 Fix Bzlmod module name typo #2363

Closed lalten closed 3 weeks ago

lalten commented 1 month ago

Notes for Reviewer

Currently if you want to depend on Iceoryx as a Bzlmod bazel_dep you have to do something like

bazel_dep(name = "org_eclipse_iceroyx", repo_name = "iceoryx")
git_override(
    module_name = "org_eclipse_iceroyx",
    commit = "00c5349eabfb1bce5db46efefb39fd9471679be1",
    patches = ["//third_party/iceoryx:iceoryx.patch"],
    remote = "https://github.com/eclipse-iceoryx/iceoryx",
)

It would be nice to fix that typo.

I'll send some follow up PRs to contribute patches that make depending on the module via Bzlmod actually work.

Pre-Review Checklist for the PR Author

  1. [x] Code follows the coding style of CONTRIBUTING.md
  2. [x] Tests follow the best practice for testing
  3. [x] Changelog updated in the unreleased section including API breaking changes
  4. [x] Branch follows the naming format (iox-123-this-is-a-branch)
  5. [x] Commits messages are according to this guideline
  6. [x] Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. [x] Relevant issues are linked
  8. [x] Add sensible notes for the reviewer
  9. [x] All checks have passed (except task-list-completed)
  10. [x] Assign PR to reviewer

Checklist for the PR Reviewer

Post-review Checklist for the PR Author

  1. [x] All open points are addressed and tracked via issues

References

elfenpiff commented 1 month ago

@lalten Thanks for the contribution. Since we are an open source project under the eclipse foundation you need to sign the ECA: https://www.eclipse.org/legal/eca/

We are targeting mission-critical systems and this requires that every change in the repo must be connected to an issue. So could you please create an issue.

Also every commit must have the prefix iox-#??? where ??? is the issue number.

lalten commented 1 month ago

@elfenpiff please have another look.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.71%. Comparing base (fc86354) to head (3978c63). Report is 3 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2363/graphs/tree.svg?width=650&height=150&src=pr&token=KWu8wdCc1S&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx)](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2363?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) ```diff @@ Coverage Diff @@ ## main #2363 +/- ## ========================================== + Coverage 78.69% 78.71% +0.01% ========================================== Files 440 440 Lines 16981 16981 Branches 2361 2361 ========================================== + Hits 13364 13366 +2 + Misses 2736 2735 -1 + Partials 881 880 -1 ``` | [Flag](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2363/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2363/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) | `78.51% <ø> (+0.01%)` | :arrow_up: | | [unittests_timing](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2363/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) | `15.35% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#carryforward-flags-in-the-pull-request-comment) to find out more. [see 3 files with indirect coverage changes](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx/pull/2363/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx)
elfenpiff commented 1 month ago

@lalten Looks good. I created this issue #2364 for you. Could you please adjust your commit message so that the prefix is iox-#2364 - then we can merge this PR.

lalten commented 1 month ago

@elfenpiff anything left to do on my side for this PR?

elBoberido commented 1 month ago

@lalten can you please rebase? We deactivated the Cirrus CI on main since we ran out of credits for the open source project.

elBoberido commented 3 weeks ago

@lalten thanks for your contribution and sorry letting you wait so long with the merge :)