eclipse-iceoryx / iceoryx

Eclipse iceoryx™ - true zero-copy inter-process-communication
https://iceoryx.io
Apache License 2.0
1.62k stars 383 forks source link

Remove #define private public from all tests #529

Closed dkroenke closed 3 years ago

dkroenke commented 3 years ago

Required information

In some of the iceoryx tests are defines used for making private=public which is against our principle of white-box testing. Additionally this doesn't compile on windows.

Task

elBoberido commented 3 years ago

oh, I also added it to the Windows Issue. Nevertheless, test_gw_gateway_discovery.cpp will be fixed with the Duration PR

dkroenke commented 3 years ago

@elBoberido yes right, this is for the new contributors to get familiar.

elBoberido commented 3 years ago

@dkroenke I had a look at it yesterday and at least one is not quite trivial to solve. Shall I tag the files from easy to difficult?

dkroenke commented 3 years ago

@elBoberido Yes that definitely make sense

elBoberido commented 3 years ago

@dkroenke done. I think mq_interface will be refactored in the near future and should maybe be done with that refactoring