Improving `units::Duration`

eclipse-iceoryx / iceoryx

Eclipse iceoryx™ - true zero-copy inter-process-communication

https://iceoryx.io

Apache License 2.0

1.69k stars 397 forks source link

Improving `units::Duration` #536

Open elBoberido opened 3 years ago

elBoberido commented 3 years ago

Brief feature description

The units::Duration class could have same additional features and improvements.

Detailed information

[x] rename the creation methods like milliseconds to fromMilliseconds
- some getter methods should then be renamed, e.g. milliSeconds -> milliseconds or toMilliseconds
- no final decision, please ask before starting with this
[ ] conversion to/from all chrono types
[x] operator+=, operator-= and operator*= https://github.com/eclipse-iceoryx/iceoryx/pull/501#discussion_r564463012
[ ] abstractions for TimePoint for monotonic and system clock https://github.com/eclipse-iceoryx/iceoryx/pull/501#discussion_r560061177
- needs to be discussed and maybe another issue should be used for this

enkeyz commented 3 years ago

Could work on refactoring method names in units::Duration(first one), if it's still wanted.

elfenpiff commented 3 years ago

@enkeyz It is still wanted and we would very much appreciate it!

I would assign the issue to you and if you run into troubles or other issues just contact us via https://gitter.im/eclipse/iceoryx

elBoberido commented 3 years ago

@enkeyz sure, go ahead. If it's not too late, please rename the getter methods with a to prefix, so toDays, toNanoseconds. This makes it's less ambiguous than just nonoseconds which could also mean just to nanoseconds part of the duration.

elfenpiff commented 3 years ago

Already finished with it, just one question: how to correctly run the "run_all_tests.sh" from tools folder?

@enkeyz nice!

Getting error message: "make: *** No rule to make target 'all_tests'. Stop."

I would recommend to use the iceoryx_meta approach for developing. Here you can compile and run the tests with the following commands:

cd iceoryx
cmake -Bbuild -Hiceoryx_meta -DBUILD_TEST=ON
cd build
make
make all_tests # executes all unit- and integrationtests