eclipse-iceoryx / iceoryx2

Eclipse iceoryx2™ - true zero-copy inter-process-communication in pure Rust
https://iceoryx.io
Apache License 2.0
449 stars 22 forks source link

[#100] dynamic segment rc owned #107

Closed elfenpiff closed 4 months ago

elfenpiff commented 4 months ago

Notes for Reviewer

Pre-Review Checklist for the PR Author

  1. [x] Add sensible notes for the reviewer
  2. [x] PR title is short, expressive and meaningful
  3. [x] Relevant issues are linked
  4. [x] Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  5. [x] Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  6. [x] Commits messages are according to this guideline
    • [x] Commit messages have the issue ID ([#123] Add posix ipc example)
    • [x] Commit author matches Eclipse Contributor Agreement (and ECA is signed)
  7. [x] Tests follow the best practice for testing
  8. [x] Changelog updated in the unreleased section including API breaking changes
  9. [x] Assign PR to reviewer
  10. [x] All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

Post-review Checklist for the PR Author

  1. [x] All open points are addressed and tracked via issues

References

Use either 'Closes #123' or 'Relates to #123' to reference the corresponding issue.

Relates to #100

codecov[bot] commented 4 months ago

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (477a193) 77.96% compared to head (85b9c9d) 77.95%. Report is 3 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/107/graphs/tree.svg?width=650&height=150&src=pr&token=FN3YFXTJCI&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx)](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/107?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) ```diff @@ Coverage Diff @@ ## main #107 +/- ## ========================================== - Coverage 77.96% 77.95% -0.02% ========================================== Files 177 177 Lines 18768 18881 +113 ========================================== + Hits 14633 14718 +85 - Misses 4135 4163 +28 ``` | [Files](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/107?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) | Coverage Δ | | |---|---|---| | [iceoryx2-bb/posix/src/shared\_memory.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/107?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDItYmIvcG9zaXgvc3JjL3NoYXJlZF9tZW1vcnkucnM=) | `81.60% <100.00%> (ø)` | | | [iceoryx2-cal/src/dynamic\_storage/mod.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/107?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDItY2FsL3NyYy9keW5hbWljX3N0b3JhZ2UvbW9kLnJz) | `100.00% <ø> (ø)` | | | [...yx2-cal/src/dynamic\_storage/posix\_shared\_memory.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/107?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDItY2FsL3NyYy9keW5hbWljX3N0b3JhZ2UvcG9zaXhfc2hhcmVkX21lbW9yeS5ycw==) | `93.36% <100.00%> (ø)` | | | [iceoryx2-cal/src/dynamic\_storage/process\_local.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/107?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDItY2FsL3NyYy9keW5hbWljX3N0b3JhZ2UvcHJvY2Vzc19sb2NhbC5ycw==) | `95.18% <100.00%> (ø)` | | | [...al/src/zero\_copy\_connection/posix\_shared\_memory.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/107?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDItY2FsL3NyYy96ZXJvX2NvcHlfY29ubmVjdGlvbi9wb3NpeF9zaGFyZWRfbWVtb3J5LnJz) | `90.00% <100.00%> (ø)` | | | [iceoryx2/src/port/notifier.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/107?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDIvc3JjL3BvcnQvbm90aWZpZXIucnM=) | `86.29% <100.00%> (+0.57%)` | :arrow_up: | | [iceoryx2/src/port/publisher.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/107?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDIvc3JjL3BvcnQvcHVibGlzaGVyLnJz) | `83.22% <100.00%> (+0.71%)` | :arrow_up: | | [iceoryx2/src/port/subscriber.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/107?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDIvc3JjL3BvcnQvc3Vic2NyaWJlci5ycw==) | `77.07% <100.00%> (+1.89%)` | :arrow_up: | | [iceoryx2/src/service/builder/publish\_subscribe.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/107?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDIvc3JjL3NlcnZpY2UvYnVpbGRlci9wdWJsaXNoX3N1YnNjcmliZS5ycw==) | `78.93% <100.00%> (-1.21%)` | :arrow_down: | | [iceoryx2/src/service/dynamic\_config/event.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/107?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDIvc3JjL3NlcnZpY2UvZHluYW1pY19jb25maWcvZXZlbnQucnM=) | `89.47% <100.00%> (+1.97%)` | :arrow_up: | | ... and [7 more](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/107?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) | | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/107/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx)