search

eclipse-iceoryx / iceoryx2

Eclipse iceoryx2™ - true zero-copy inter-process-communication in pure Rust
https://iceoryx.io
Apache License 2.0
449 stars 22 forks source link

[#100] pub sub without lifetime arg #114

Closed elfenpiff closed 4 months ago

elfenpiff commented 4 months ago

Notes for Reviewer

Pre-Review Checklist for the PR Author

  1. [x] Add sensible notes for the reviewer
  2. [x] PR title is short, expressive and meaningful
  3. [x] Relevant issues are linked
  4. [x] Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  5. [x] Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  6. [x] Commits messages are according to this guideline
    • [x] Commit messages have the issue ID ([#123] Add posix ipc example)
    • [x] Commit author matches Eclipse Contributor Agreement (and ECA is signed)
  7. [x] Tests follow the best practice for testing
  8. [x] Changelog updated in the unreleased section including API breaking changes
  9. [x] Assign PR to reviewer
  10. [x] All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

Post-review Checklist for the PR Author

  1. [x] All open points are addressed and tracked via issues

References

Relates to #100

codecov[bot] commented 4 months ago

Codecov Report

Attention: 86 lines in your changes are missing coverage. Please review.

Comparison is base (80db0c4) 77.38% compared to head (637e681) 77.37%.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/114/graphs/tree.svg?width=650&height=150&src=pr&token=FN3YFXTJCI&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx)](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/114?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) ```diff @@ Coverage Diff @@ ## main #114 +/- ## ========================================== - Coverage 77.38% 77.37% -0.02% ========================================== Files 181 177 -4 Lines 19599 19620 +21 ========================================== + Hits 15166 15180 +14 - Misses 4433 4440 +7 ``` | [Files](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/114?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) | Coverage Δ | | |---|---|---| | [iceoryx2/src/port/mod.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/114?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDIvc3JjL3BvcnQvbW9kLnJz) | `0.00% <ø> (ø)` | | | [iceoryx2/src/port/update\_connections.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/114?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDIvc3JjL3BvcnQvdXBkYXRlX2Nvbm5lY3Rpb25zLnJz) | `0.00% <ø> (ø)` | | | [iceoryx2/src/service/port\_factory/listener.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/114?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDIvc3JjL3NlcnZpY2UvcG9ydF9mYWN0b3J5L2xpc3RlbmVyLnJz) | `60.00% <ø> (ø)` | | | [iceoryx2/src/service/port\_factory/notifier.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/114?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDIvc3JjL3NlcnZpY2UvcG9ydF9mYWN0b3J5L25vdGlmaWVyLnJz) | `87.50% <ø> (ø)` | | | [...ryx2/src/service/port\_factory/publish\_subscribe.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/114?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDIvc3JjL3NlcnZpY2UvcG9ydF9mYWN0b3J5L3B1Ymxpc2hfc3Vic2NyaWJlLnJz) | `89.65% <100.00%> (ø)` | | | [iceoryx2/src/sample\_mut.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/114?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDIvc3JjL3NhbXBsZV9tdXQucnM=) | `80.55% <80.00%> (-2.78%)` | :arrow_down: | | [iceoryx2/src/port/listener.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/114?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDIvc3JjL3BvcnQvbGlzdGVuZXIucnM=) | `58.75% <25.00%> (-3.10%)` | :arrow_down: | | [iceoryx2/src/sample.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/114?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDIvc3JjL3NhbXBsZS5ycw==) | `47.82% <46.15%> (-2.18%)` | :arrow_down: | | [iceoryx2/src/port/notifier.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/114?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDIvc3JjL3BvcnQvbm90aWZpZXIucnM=) | `81.06% <20.00%> (-5.23%)` | :arrow_down: | | [iceoryx2/src/port/subscriber.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/114?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDIvc3JjL3BvcnQvc3Vic2NyaWJlci5ycw==) | `83.45% <59.09%> (+6.38%)` | :arrow_up: | | ... and [3 more](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/114?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/114/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx)