eclipse-iceoryx / iceoryx2

Eclipse iceoryx2™ - true zero-copy inter-process-communication in pure Rust
https://iceoryx.io
Apache License 2.0
569 stars 26 forks source link

[#153] use dynamic storage in shared memory #155

Closed elfenpiff closed 6 months ago

elfenpiff commented 6 months ago

Notes for Reviewer

Pre-Review Checklist for the PR Author

  1. [x] Add sensible notes for the reviewer
  2. [x] PR title is short, expressive and meaningful
  3. [x] Relevant issues are linked in the References section
  4. [x] Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  5. [x] Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  6. [x] Commits messages are according to this guideline
    • [x] Commit messages have the issue ID ([#123] Add posix ipc example)
    • [x] Commit author matches Eclipse Contributor Agreement (and ECA is signed)
  7. [x] Tests follow the best practice for testing
  8. [x] Changelog updated in the unreleased section including API breaking changes
  9. [x] Assign PR to reviewer
  10. [x] All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

Post-review Checklist for the PR Author

  1. [x] All open points are addressed and tracked via issues

References

Relates to #153 Closes #14

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 86.87259% with 68 lines in your changes are missing coverage. Please review.

Project coverage is 77.57%. Comparing base (e4c339f) to head (b71de04). Report is 8 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/155/graphs/tree.svg?width=650&height=150&src=pr&token=FN3YFXTJCI&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx)](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/155?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) ```diff @@ Coverage Diff @@ ## main #155 +/- ## ========================================== - Coverage 77.77% 77.57% -0.21% ========================================== Files 180 181 +1 Lines 19970 19993 +23 ========================================== - Hits 15532 15509 -23 - Misses 4438 4484 +46 ``` | [Files](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/155?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) | Coverage Δ | | |---|---|---| | [iceoryx2-bb/elementary/src/package\_version.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/155?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDItYmIvZWxlbWVudGFyeS9zcmMvcGFja2FnZV92ZXJzaW9uLnJz) | `100.00% <100.00%> (ø)` | | | [...l/src/communication\_channel/posix\_shared\_memory.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/155?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDItY2FsL3NyYy9jb21tdW5pY2F0aW9uX2NoYW5uZWwvcG9zaXhfc2hhcmVkX21lbW9yeS5ycw==) | `82.75% <100.00%> (-0.20%)` | :arrow_down: | | [iceoryx2-cal/src/dynamic\_storage/mod.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/155?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDItY2FsL3NyYy9keW5hbWljX3N0b3JhZ2UvbW9kLnJz) | `100.00% <100.00%> (ø)` | | | [iceoryx2-cal/src/shared\_memory/mod.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/155?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDItY2FsL3NyYy9zaGFyZWRfbWVtb3J5L21vZC5ycw==) | `100.00% <ø> (ø)` | | | [iceoryx2-cal/src/shm\_allocator/bump\_allocator.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/155?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDItY2FsL3NyYy9zaG1fYWxsb2NhdG9yL2J1bXBfYWxsb2NhdG9yLnJz) | `98.33% <100.00%> (ø)` | | | [iceoryx2-cal/src/shm\_allocator/mod.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/155?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDItY2FsL3NyYy9zaG1fYWxsb2NhdG9yL21vZC5ycw==) | `100.00% <ø> (ø)` | | | [iceoryx2-cal/src/shm\_allocator/pool\_allocator.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/155?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDItY2FsL3NyYy9zaG1fYWxsb2NhdG9yL3Bvb2xfYWxsb2NhdG9yLnJz) | `96.10% <100.00%> (ø)` | | | [iceoryx2/src/service/builder/mod.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/155?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDIvc3JjL3NlcnZpY2UvYnVpbGRlci9tb2QucnM=) | `83.54% <100.00%> (-0.54%)` | :arrow_down: | | [iceoryx2-bb/memory/src/pool\_allocator.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/155?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDItYmIvbWVtb3J5L3NyYy9wb29sX2FsbG9jYXRvci5ycw==) | `91.36% <50.00%> (-0.04%)` | :arrow_down: | | [iceoryx2-bb/posix/src/shared\_memory.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/155?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDItYmIvcG9zaXgvc3JjL3NoYXJlZF9tZW1vcnkucnM=) | `79.71% <50.00%> (-1.53%)` | :arrow_down: | | ... and [3 more](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/155?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) | | ... and [8 files with indirect coverage changes](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/155/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx)