search

eclipse-iceoryx / iceoryx2

Eclipse iceoryx2™ - true zero-copy inter-process-communication in pure Rust
https://iceoryx.io
Apache License 2.0
448 stars 22 forks source link

[#160] type safe dynamic storage #161

Closed elfenpiff closed 3 months ago

elfenpiff commented 3 months ago

Notes for Reviewer

Pre-Review Checklist for the PR Author

  1. [x] Add sensible notes for the reviewer
  2. [x] PR title is short, expressive and meaningful
  3. [x] Relevant issues are linked in the References section
  4. [x] Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  5. [x] Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  6. [x] Commits messages are according to this guideline
    • [x] Commit messages have the issue ID ([#123] Add posix ipc example)
    • [x] Commit author matches Eclipse Contributor Agreement (and ECA is signed)
  7. [x] Tests follow the best practice for testing
  8. [x] Changelog updated in the unreleased section including API breaking changes
  9. [x] Assign PR to reviewer
  10. [x] All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

Post-review Checklist for the PR Author

  1. [x] All open points are addressed and tracked via issues

References

Closes #160

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 84.61538% with 26 lines in your changes are missing coverage. Please review.

Project coverage is 77.93%. Comparing base (124eaed) to head (cf74b01).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/161/graphs/tree.svg?width=650&height=150&src=pr&token=FN3YFXTJCI&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx)](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/161?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) ```diff @@ Coverage Diff @@ ## main #161 +/- ## ========================================== + Coverage 77.19% 77.93% +0.73% ========================================== Files 180 179 -1 Lines 19587 19378 -209 ========================================== - Hits 15120 15102 -18 + Misses 4467 4276 -191 ``` | [Files](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/161?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) | Coverage Δ | | |---|---|---| | [...l/src/communication\_channel/posix\_shared\_memory.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/161?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDItY2FsL3NyYy9jb21tdW5pY2F0aW9uX2NoYW5uZWwvcG9zaXhfc2hhcmVkX21lbW9yeS5ycw==) | `85.02% <ø> (+2.27%)` | :arrow_up: | | [iceoryx2-cal/src/dynamic\_storage/mod.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/161?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDItY2FsL3NyYy9keW5hbWljX3N0b3JhZ2UvbW9kLnJz) | `100.00% <ø> (ø)` | | | [iceoryx2-cal/src/shared\_memory/common.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/161?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDItY2FsL3NyYy9zaGFyZWRfbWVtb3J5L2NvbW1vbi5ycw==) | `86.95% <100.00%> (+0.94%)` | :arrow_up: | | [iceoryx2-cal/src/shared\_memory/mod.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/161?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDItY2FsL3NyYy9zaGFyZWRfbWVtb3J5L21vZC5ycw==) | `100.00% <ø> (ø)` | | | [iceoryx2-cal/src/shared\_memory\_directory/mod.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/161?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDItY2FsL3NyYy9zaGFyZWRfbWVtb3J5X2RpcmVjdG9yeS9tb2QucnM=) | `90.41% <100.00%> (+0.05%)` | :arrow_up: | | [iceoryx2-cal/src/dynamic\_storage/process\_local.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/161?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDItY2FsL3NyYy9keW5hbWljX3N0b3JhZ2UvcHJvY2Vzc19sb2NhbC5ycw==) | `95.65% <97.22%> (+0.67%)` | :arrow_up: | | [iceoryx2-bb/testing/src/lifetime\_tracker.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/161?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDItYmIvdGVzdGluZy9zcmMvbGlmZXRpbWVfdHJhY2tlci5ycw==) | `85.71% <85.71%> (ø)` | | | [...yx2-cal/src/dynamic\_storage/posix\_shared\_memory.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/161?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDItY2FsL3NyYy9keW5hbWljX3N0b3JhZ2UvcG9zaXhfc2hhcmVkX21lbW9yeS5ycw==) | `92.56% <87.17%> (+0.77%)` | :arrow_up: | | [...c/dynamic\_storage/dynamic\_storage\_configuration.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/161?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDItY2FsL3NyYy9keW5hbWljX3N0b3JhZ2UvZHluYW1pY19zdG9yYWdlX2NvbmZpZ3VyYXRpb24ucnM=) | `66.00% <66.00%> (ø)` | | ... and [124 files with indirect coverage changes](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/161/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx)