eclipse-iceoryx / iceoryx2

Eclipse iceoryx2™ - true zero-copy inter-process-communication in pure Rust
https://iceoryx.io
Apache License 2.0
448 stars 22 forks source link

[#162] refactor ipc capable trait #163

Closed elfenpiff closed 3 months ago

elfenpiff commented 3 months ago

Notes for Reviewer

Pre-Review Checklist for the PR Author

  1. [x] Add sensible notes for the reviewer
  2. [x] PR title is short, expressive and meaningful
  3. [x] Relevant issues are linked in the References section
  4. [x] Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  5. [x] Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  6. [x] Commits messages are according to this guideline
    • [x] Commit messages have the issue ID ([#123] Add posix ipc example)
    • [x] Commit author matches Eclipse Contributor Agreement (and ECA is signed)
  7. [x] Tests follow the best practice for testing
  8. [x] Changelog updated in the unreleased section including API breaking changes
  9. [x] Assign PR to reviewer
  10. [x] All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

Post-review Checklist for the PR Author

  1. [ ] All open points are addressed and tracked via issues

References

Closes #162

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 89.38776% with 26 lines in your changes are missing coverage. Please review.

Project coverage is 77.95%. Comparing base (43f26f1) to head (743a798).

:exclamation: Current head 743a798 differs from pull request most recent head dcd8c43. Consider uploading reports for the commit dcd8c43 to get more accurate results

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/163/graphs/tree.svg?width=650&height=150&src=pr&token=FN3YFXTJCI&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx)](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/163?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) ```diff @@ Coverage Diff @@ ## main #163 +/- ## ========================================== + Coverage 77.92% 77.95% +0.03% ========================================== Files 179 177 -2 Lines 19378 19207 -171 ========================================== - Hits 15100 14973 -127 + Misses 4278 4234 -44 ``` | [Files](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/163?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) | Coverage Δ | | |---|---|---| | [iceoryx2-bb/posix/src/condition\_variable.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/163?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDItYmIvcG9zaXgvc3JjL2NvbmRpdGlvbl92YXJpYWJsZS5ycw==) | `76.69% <100.00%> (ø)` | | | [iceoryx2-bb/posix/src/file\_lock.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/163?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDItYmIvcG9zaXgvc3JjL2ZpbGVfbG9jay5ycw==) | `79.06% <ø> (ø)` | | | [iceoryx2-bb/threadsafe/src/trigger\_queue.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/163?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDItYmIvdGhyZWFkc2FmZS9zcmMvdHJpZ2dlcl9xdWV1ZS5ycw==) | `88.17% <ø> (ø)` | | | [iceoryx2-cal/src/dynamic\_storage/process\_local.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/163?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDItY2FsL3NyYy9keW5hbWljX3N0b3JhZ2UvcHJvY2Vzc19sb2NhbC5ycw==) | `95.25% <ø> (-0.40%)` | :arrow_down: | | [iceoryx2-cal/src/event/process\_local.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/163?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDItY2FsL3NyYy9ldmVudC9wcm9jZXNzX2xvY2FsLnJz) | `86.83% <ø> (ø)` | | | [iceoryx2-bb/posix/src/ipc\_capable.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/163?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDItYmIvcG9zaXgvc3JjL2lwY19jYXBhYmxlLnJz) | `96.87% <96.87%> (ø)` | | | [iceoryx2-bb/posix/src/read\_write\_mutex.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/163?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDItYmIvcG9zaXgvc3JjL3JlYWRfd3JpdGVfbXV0ZXgucnM=) | `74.00% <88.88%> (+0.08%)` | :arrow_up: | | [iceoryx2-bb/posix/src/barrier.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/163?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDItYmIvcG9zaXgvc3JjL2JhcnJpZXIucnM=) | `77.65% <85.36%> (+3.82%)` | :arrow_up: | | [iceoryx2-bb/posix/src/mutex.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/163?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDItYmIvcG9zaXgvc3JjL211dGV4LnJz) | `61.87% <86.95%> (-1.15%)` | :arrow_down: | | [iceoryx2-bb/posix/src/semaphore.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/163?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDItYmIvcG9zaXgvc3JjL3NlbWFwaG9yZS5ycw==) | `77.02% <85.10%> (+0.24%)` | :arrow_up: | ... and [12 files with indirect coverage changes](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/163/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx)