search

eclipse-iceoryx / iceoryx2

Eclipse iceoryx2™ - true zero-copy inter-process-communication in pure Rust
https://iceoryx.io
Apache License 2.0
448 stars 22 forks source link

[#139] events with bitset #167

Closed elfenpiff closed 2 months ago

elfenpiff commented 2 months ago

Notes for Reviewer

Pre-Review Checklist for the PR Author

  1. [x] Add sensible notes for the reviewer
  2. [x] PR title is short, expressive and meaningful
  3. [x] Relevant issues are linked in the References section
  4. [x] Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  5. [x] Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  6. [x] Commits messages are according to this guideline
    • [x] Commit messages have the issue ID ([#123] Add posix ipc example)
    • [x] Commit author matches Eclipse Contributor Agreement (and ECA is signed)
  7. [x] Tests follow the best practice for testing
  8. [x] Changelog updated in the unreleased section including API breaking changes
  9. [x] Assign PR to reviewer
  10. [x] All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

Post-review Checklist for the PR Author

  1. [x] All open points are addressed and tracked via issues

References

Relates to #139

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 81.74098% with 86 lines in your changes are missing coverage. Please review.

Project coverage is 78.22%. Comparing base (b7f04eb) to head (b426ca7). Report is 7 commits behind head on main.

:exclamation: Current head b426ca7 differs from pull request most recent head 9ca036a. Consider uploading reports for the commit 9ca036a to get more accurate results

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/167/graphs/tree.svg?width=650&height=150&src=pr&token=FN3YFXTJCI&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx)](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/167?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) ```diff @@ Coverage Diff @@ ## main #167 +/- ## ========================================== + Coverage 78.00% 78.22% +0.21% ========================================== Files 179 181 +2 Lines 19363 19749 +386 ========================================== + Hits 15105 15448 +343 - Misses 4258 4301 +43 ``` | [Files](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/167?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) | Coverage Δ | | |---|---|---| | [iceoryx2-bb/posix/src/semaphore.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/167?src=pr&el=tree&filepath=iceoryx2-bb%2Fposix%2Fsrc%2Fsemaphore.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDItYmIvcG9zaXgvc3JjL3NlbWFwaG9yZS5ycw==) | `77.02% <100.00%> (ø)` | | | [iceoryx2-bb/threadsafe/src/trigger\_queue.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/167?src=pr&el=tree&filepath=iceoryx2-bb%2Fthreadsafe%2Fsrc%2Ftrigger_queue.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDItYmIvdGhyZWFkc2FmZS9zcmMvdHJpZ2dlcl9xdWV1ZS5ycw==) | `88.17% <100.00%> (ø)` | | | [iceoryx2-cal/src/shared\_memory/common.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/167?src=pr&el=tree&filepath=iceoryx2-cal%2Fsrc%2Fshared_memory%2Fcommon.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDItY2FsL3NyYy9zaGFyZWRfbWVtb3J5L2NvbW1vbi5ycw==) | `86.95% <ø> (ø)` | | | [iceoryx2/src/port/listener.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/167?src=pr&el=tree&filepath=iceoryx2%2Fsrc%2Fport%2Flistener.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDIvc3JjL3BvcnQvbGlzdGVuZXIucnM=) | `59.77% <100.00%> (ø)` | | | [iceoryx2/src/service/mod.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/167?src=pr&el=tree&filepath=iceoryx2%2Fsrc%2Fservice%2Fmod.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDIvc3JjL3NlcnZpY2UvbW9kLnJz) | `71.73% <ø> (ø)` | | | [iceoryx2/src/service/process\_local.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/167?src=pr&el=tree&filepath=iceoryx2%2Fsrc%2Fservice%2Fprocess_local.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDIvc3JjL3NlcnZpY2UvcHJvY2Vzc19sb2NhbC5ycw==) | `66.66% <ø> (ø)` | | | [iceoryx2/src/service/zero\_copy.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/167?src=pr&el=tree&filepath=iceoryx2%2Fsrc%2Fservice%2Fzero_copy.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDIvc3JjL3NlcnZpY2UvemVyb19jb3B5LnJz) | `66.66% <ø> (ø)` | | | [iceoryx2-cal/src/zero\_copy\_connection/common.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/167?src=pr&el=tree&filepath=iceoryx2-cal%2Fsrc%2Fzero_copy_connection%2Fcommon.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDItY2FsL3NyYy96ZXJvX2NvcHlfY29ubmVjdGlvbi9jb21tb24ucnM=) | `91.72% <60.00%> (-0.52%)` | :arrow_down: | | [iceoryx2-cal/src/event/id\_tracker/bit\_set.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/167?src=pr&el=tree&filepath=iceoryx2-cal%2Fsrc%2Fevent%2Fid_tracker%2Fbit_set.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDItY2FsL3NyYy9ldmVudC9pZF90cmFja2VyL2JpdF9zZXQucnM=) | `85.71% <85.71%> (ø)` | | | [iceoryx2-cal/src/event/mod.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/167?src=pr&el=tree&filepath=iceoryx2-cal%2Fsrc%2Fevent%2Fmod.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDItY2FsL3NyYy9ldmVudC9tb2QucnM=) | `44.44% <75.00%> (+24.44%)` | :arrow_up: | | ... and [6 more](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/167?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) | | ... and [4 files with indirect coverage changes](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/167/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx)