search

eclipse-iceoryx / iceoryx2

Eclipse iceoryx2™ - true zero-copy inter-process-communication in pure Rust
https://iceoryx.io
Apache License 2.0
448 stars 22 forks source link

[#139] fix event concurrency issues #186

Closed elfenpiff closed 2 months ago

elfenpiff commented 2 months ago

Notes for Reviewer

Pre-Review Checklist for the PR Author

  1. [x] Add sensible notes for the reviewer
  2. [x] PR title is short, expressive and meaningful
  3. [x] Relevant issues are linked in the References section
  4. [x] Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  5. [x] Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  6. [x] Commits messages are according to this guideline
    • [x] Commit messages have the issue ID ([#123] Add posix ipc example)
    • [x] Commit author matches Eclipse Contributor Agreement (and ECA is signed)
  7. [x] Tests follow the best practice for testing
  8. [x] Changelog updated in the unreleased section including API breaking changes
  9. [x] Assign PR to reviewer
  10. [x] All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

Post-review Checklist for the PR Author

  1. [x] All open points are addressed and tracked via issues

References

Closes #139

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 91.66667% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 78.62%. Comparing base (d25b7df) to head (7db6a96). Report is 3 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/186/graphs/tree.svg?width=650&height=150&src=pr&token=FN3YFXTJCI&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx)](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/186?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) ```diff @@ Coverage Diff @@ ## main #186 +/- ## ========================================== + Coverage 78.54% 78.62% +0.08% ========================================== Files 181 181 Lines 19837 19922 +85 ========================================== + Hits 15580 15663 +83 - Misses 4257 4259 +2 ``` | [Files](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/186?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) | Coverage Δ | | |---|---|---| | [iceoryx2-bb/posix/src/unix\_datagram\_socket.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/186?src=pr&el=tree&filepath=iceoryx2-bb%2Fposix%2Fsrc%2Funix_datagram_socket.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDItYmIvcG9zaXgvc3JjL3VuaXhfZGF0YWdyYW1fc29ja2V0LnJz) | `67.53% <100.00%> (+0.23%)` | :arrow_up: | | [iceoryx2-cal/src/event/common.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/186?src=pr&el=tree&filepath=iceoryx2-cal%2Fsrc%2Fevent%2Fcommon.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDItY2FsL3NyYy9ldmVudC9jb21tb24ucnM=) | `87.85% <100.00%> (+2.24%)` | :arrow_up: | | [iceoryx2-cal/src/event/mod.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/186?src=pr&el=tree&filepath=iceoryx2-cal%2Fsrc%2Fevent%2Fmod.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDItY2FsL3NyYy9ldmVudC9tb2QucnM=) | `44.44% <ø> (ø)` | | | [iceoryx2-cal/src/event/process\_local.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/186?src=pr&el=tree&filepath=iceoryx2-cal%2Fsrc%2Fevent%2Fprocess_local.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDItY2FsL3NyYy9ldmVudC9wcm9jZXNzX2xvY2FsLnJz) | `87.10% <100.00%> (+0.97%)` | :arrow_up: | | [iceoryx2/src/port/details/publisher\_connections.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/186?src=pr&el=tree&filepath=iceoryx2%2Fsrc%2Fport%2Fdetails%2Fpublisher_connections.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDIvc3JjL3BvcnQvZGV0YWlscy9wdWJsaXNoZXJfY29ubmVjdGlvbnMucnM=) | `95.94% <100.00%> (ø)` | | | [...ceoryx2/src/port/details/subscriber\_connections.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/186?src=pr&el=tree&filepath=iceoryx2%2Fsrc%2Fport%2Fdetails%2Fsubscriber_connections.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDIvc3JjL3BvcnQvZGV0YWlscy9zdWJzY3JpYmVyX2Nvbm5lY3Rpb25zLnJz) | `98.43% <100.00%> (ø)` | | | [iceoryx2/src/port/listener.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/186?src=pr&el=tree&filepath=iceoryx2%2Fsrc%2Fport%2Flistener.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDIvc3JjL3BvcnQvbGlzdGVuZXIucnM=) | `79.54% <100.00%> (ø)` | | | [iceoryx2/src/port/publisher.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/186?src=pr&el=tree&filepath=iceoryx2%2Fsrc%2Fport%2Fpublisher.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDIvc3JjL3BvcnQvcHVibGlzaGVyLnJz) | `83.15% <100.00%> (+0.26%)` | :arrow_up: | | [iceoryx2/src/port/subscriber.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/186?src=pr&el=tree&filepath=iceoryx2%2Fsrc%2Fport%2Fsubscriber.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDIvc3JjL3BvcnQvc3Vic2NyaWJlci5ycw==) | `84.47% <100.00%> (ø)` | | | [iceoryx2/src/sample.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/186?src=pr&el=tree&filepath=iceoryx2%2Fsrc%2Fsample.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDIvc3JjL3NhbXBsZS5ycw==) | `70.83% <ø> (ø)` | | | ... and [7 more](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/186?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) | | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/186/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx)