search

eclipse-iceoryx / iceoryx2

Eclipse iceoryx2™ - true zero-copy inter-process-communication in pure Rust
https://iceoryx.io
Apache License 2.0
444 stars 22 forks source link

[#19] reduce buffer size on subscriber side #198

Closed elfenpiff closed 2 months ago

elfenpiff commented 2 months ago

Notes for Reviewer

Pre-Review Checklist for the PR Author

  1. [x] Add sensible notes for the reviewer
  2. [x] PR title is short, expressive and meaningful
  3. [x] Relevant issues are linked in the References section
  4. [x] Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  5. [x] Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  6. [x] Commits messages are according to this guideline
    • [x] Commit messages have the issue ID ([#123] Add posix ipc example)
    • [x] Commit author matches Eclipse Contributor Agreement (and ECA is signed)
  7. [x] Tests follow the best practice for testing
  8. [x] Changelog updated in the unreleased section including API breaking changes
  9. [x] Assign PR to reviewer
  10. [x] All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

Post-review Checklist for the PR Author

  1. [x] All open points are addressed and tracked via issues

References

Closes #19

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 78.33333% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 78.54%. Comparing base (a33cc28) to head (ec4fd57). Report is 4 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/198/graphs/tree.svg?width=650&height=150&src=pr&token=FN3YFXTJCI&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx)](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/198?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) ```diff @@ Coverage Diff @@ ## main #198 +/- ## ========================================== - Coverage 78.56% 78.54% -0.02% ========================================== Files 181 181 Lines 19933 19970 +37 ========================================== + Hits 15660 15686 +26 - Misses 4273 4284 +11 ``` | [Files](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/198?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) | Coverage Δ | | |---|---|---| | [iceoryx2/src/port/details/publisher\_connections.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/198?src=pr&el=tree&filepath=iceoryx2%2Fsrc%2Fport%2Fdetails%2Fpublisher_connections.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDIvc3JjL3BvcnQvZGV0YWlscy9wdWJsaXNoZXJfY29ubmVjdGlvbnMucnM=) | `96.05% <100.00%> (+0.10%)` | :arrow_up: | | [iceoryx2/src/port/subscriber.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/198?src=pr&el=tree&filepath=iceoryx2%2Fsrc%2Fport%2Fsubscriber.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDIvc3JjL3BvcnQvc3Vic2NyaWJlci5ycw==) | `85.79% <100.00%> (+1.32%)` | :arrow_up: | | [...x2/src/service/dynamic\_config/publish\_subscribe.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/198?src=pr&el=tree&filepath=iceoryx2%2Fsrc%2Fservice%2Fdynamic_config%2Fpublish_subscribe.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDIvc3JjL3NlcnZpY2UvZHluYW1pY19jb25maWcvcHVibGlzaF9zdWJzY3JpYmUucnM=) | `94.44% <100.00%> (ø)` | | | [iceoryx2/src/service/port\_factory/subscriber.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/198?src=pr&el=tree&filepath=iceoryx2%2Fsrc%2Fservice%2Fport_factory%2Fsubscriber.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDIvc3JjL3NlcnZpY2UvcG9ydF9mYWN0b3J5L3N1YnNjcmliZXIucnM=) | `54.28% <100.00%> (+7.61%)` | :arrow_up: | | [...ceoryx2/src/port/details/subscriber\_connections.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/198?src=pr&el=tree&filepath=iceoryx2%2Fsrc%2Fport%2Fdetails%2Fsubscriber_connections.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDIvc3JjL3BvcnQvZGV0YWlscy9zdWJzY3JpYmVyX2Nvbm5lY3Rpb25zLnJz) | `94.52% <75.00%> (-3.92%)` | :arrow_down: | | [iceoryx2/src/port/publisher.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/198?src=pr&el=tree&filepath=iceoryx2%2Fsrc%2Fport%2Fpublisher.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDIvc3JjL3BvcnQvcHVibGlzaGVyLnJz) | `81.86% <30.76%> (-1.03%)` | :arrow_down: | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/198/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx)