search

eclipse-iceoryx / iceoryx2

Eclipse iceoryx2™ - true zero-copy inter-process-communication in pure Rust
https://iceoryx.io
Apache License 2.0
444 stars 22 forks source link

[#224] implement placement new for containers #230

Closed elfenpiff closed 2 weeks ago

elfenpiff commented 3 weeks ago

Notes for Reviewer

Pre-Review Checklist for the PR Author

  1. [x] Add sensible notes for the reviewer
  2. [x] PR title is short, expressive and meaningful
  3. [x] Relevant issues are linked in the References section
  4. [x] Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  5. [x] Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  6. [x] Commits messages are according to this guideline
    • [x] Commit messages have the issue ID ([#123] Add posix ipc example)
    • [x] Commit author matches Eclipse Contributor Agreement (and ECA is signed)
  7. [x] Tests follow the best practice for testing
  8. [x] Changelog updated in the unreleased section including API breaking changes
  9. [x] Assign PR to reviewer
  10. [x] All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

Post-review Checklist for the PR Author

  1. [x] All open points are addressed and tracked via issues

References

Closes #224

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 38.88889% with 99 lines in your changes missing coverage. Please review.

Project coverage is 79.67%. Comparing base (2626216) to head (1a97e46). Report is 2 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/230/graphs/tree.svg?width=650&height=150&src=pr&token=FN3YFXTJCI&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx)](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/230?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) ```diff @@ Coverage Diff @@ ## main #230 +/- ## ========================================== - Coverage 80.02% 79.67% -0.36% ========================================== Files 183 186 +3 Lines 20426 20575 +149 ========================================== + Hits 16346 16393 +47 - Misses 4080 4182 +102 ``` | [Files](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/230?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) | Coverage Δ | | |---|---|---| | [iceoryx2-bb/container/src/byte\_string.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/230?src=pr&el=tree&filepath=iceoryx2-bb%2Fcontainer%2Fsrc%2Fbyte_string.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDItYmIvY29udGFpbmVyL3NyYy9ieXRlX3N0cmluZy5ycw==) | `99.10% <100.00%> (+<0.01%)` | :arrow_up: | | [iceoryx2-bb/container/src/queue.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/230?src=pr&el=tree&filepath=iceoryx2-bb%2Fcontainer%2Fsrc%2Fqueue.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDItYmIvY29udGFpbmVyL3NyYy9xdWV1ZS5ycw==) | `97.70% <100.00%> (+0.07%)` | :arrow_up: | | [iceoryx2-bb/container/src/vec.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/230?src=pr&el=tree&filepath=iceoryx2-bb%2Fcontainer%2Fsrc%2Fvec.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDItYmIvY29udGFpbmVyL3NyYy92ZWMucnM=) | `91.34% <100.00%> (+0.30%)` | :arrow_up: | | [iceoryx2-pal/concurrency-sync/src/iox\_atomic.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/230?src=pr&el=tree&filepath=iceoryx2-pal%2Fconcurrency-sync%2Fsrc%2Fiox_atomic.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDItcGFsL2NvbmN1cnJlbmN5LXN5bmMvc3JjL2lveF9hdG9taWMucnM=) | `96.19% <ø> (ø)` | | | [iceoryx2-bb/testing/src/memory.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/230?src=pr&el=tree&filepath=iceoryx2-bb%2Ftesting%2Fsrc%2Fmemory.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDItYmIvdGVzdGluZy9zcmMvbWVtb3J5LnJz) | `75.00% <75.00%> (ø)` | | | [iceoryx2-bb/elementary/src/placement\_default.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/230?src=pr&el=tree&filepath=iceoryx2-bb%2Felementary%2Fsrc%2Fplacement_default.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDItYmIvZWxlbWVudGFyeS9zcmMvcGxhY2VtZW50X2RlZmF1bHQucnM=) | `15.68% <15.68%> (ø)` | | | [iceoryx2-bb/derive-macros/src/lib.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/230?src=pr&el=tree&filepath=iceoryx2-bb%2Fderive-macros%2Fsrc%2Flib.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDItYmIvZGVyaXZlLW1hY3Jvcy9zcmMvbGliLnJz) | `0.00% <0.00%> (ø)` | | ... and [5 files with indirect coverage changes](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/230/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx)