search

eclipse-iceoryx / iceoryx2

Eclipse iceoryx2™ - true zero-copy inter-process-communication in pure Rust
https://iceoryx.io
Apache License 2.0
1.02k stars 38 forks source link

[#243] try into for semantic strings #245

Closed elfenpiff closed 5 months ago

elfenpiff commented 5 months ago

Notes for Reviewer

Pre-Review Checklist for the PR Author

  1. [x] Add sensible notes for the reviewer
  2. [x] PR title is short, expressive and meaningful
  3. [x] Relevant issues are linked in the References section
  4. [x] Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  5. [x] Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  6. [x] Commits messages are according to this guideline
    • [x] Commit messages have the issue ID ([#123] Add posix ipc example)
    • [x] Commit author matches Eclipse Contributor Agreement (and ECA is signed)
  7. [x] Tests follow the best practice for testing
  8. [x] Changelog updated in the unreleased section including API breaking changes
  9. [x] Assign PR to reviewer
  10. [x] All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

Post-review Checklist for the PR Author

  1. [x] All open points are addressed and tracked via issues

References

Closes #243

codecov[bot] commented 5 months ago

Codecov Report

Attention: Patch coverage is 38.46154% with 8 lines in your changes missing coverage. Please review.

Project coverage is 79.30%. Comparing base (c3b0c11) to head (a13696a).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/245/graphs/tree.svg?width=650&height=150&src=pr&token=FN3YFXTJCI&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx)](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/245?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) ```diff @@ Coverage Diff @@ ## main #245 +/- ## ========================================== - Coverage 79.36% 79.30% -0.07% ========================================== Files 194 194 Lines 21468 21474 +6 ========================================== - Hits 17039 17030 -9 - Misses 4429 4444 +15 ``` | [Files](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/245?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) | Coverage Δ | | |---|---|---| | [iceoryx2/src/config.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/245?src=pr&el=tree&filepath=iceoryx2%2Fsrc%2Fconfig.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDIvc3JjL2NvbmZpZy5ycw==) | `75.00% <ø> (ø)` | | | [iceoryx2/src/node/mod.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/245?src=pr&el=tree&filepath=iceoryx2%2Fsrc%2Fnode%2Fmod.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDIvc3JjL25vZGUvbW9kLnJz) | `70.60% <100.00%> (ø)` | | | [iceoryx2/src/port/listener.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/245?src=pr&el=tree&filepath=iceoryx2%2Fsrc%2Fport%2Flistener.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDIvc3JjL3BvcnQvbGlzdGVuZXIucnM=) | `79.54% <ø> (ø)` | | | [iceoryx2/src/port/notifier.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/245?src=pr&el=tree&filepath=iceoryx2%2Fsrc%2Fport%2Fnotifier.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDIvc3JjL3BvcnQvbm90aWZpZXIucnM=) | `83.52% <ø> (ø)` | | | [iceoryx2/src/port/publisher.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/245?src=pr&el=tree&filepath=iceoryx2%2Fsrc%2Fport%2Fpublisher.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDIvc3JjL3BvcnQvcHVibGlzaGVyLnJz) | `84.74% <ø> (ø)` | | | [iceoryx2/src/port/subscriber.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/245?src=pr&el=tree&filepath=iceoryx2%2Fsrc%2Fport%2Fsubscriber.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDIvc3JjL3BvcnQvc3Vic2NyaWJlci5ycw==) | `88.15% <ø> (ø)` | | | [iceoryx2/src/port/update\_connections.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/245?src=pr&el=tree&filepath=iceoryx2%2Fsrc%2Fport%2Fupdate_connections.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDIvc3JjL3BvcnQvdXBkYXRlX2Nvbm5lY3Rpb25zLnJz) | `0.00% <ø> (ø)` | | | [iceoryx2/src/sample.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/245?src=pr&el=tree&filepath=iceoryx2%2Fsrc%2Fsample.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDIvc3JjL3NhbXBsZS5ycw==) | `55.55% <ø> (ø)` | | | [iceoryx2/src/sample\_mut.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/245?src=pr&el=tree&filepath=iceoryx2%2Fsrc%2Fsample_mut.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDIvc3JjL3NhbXBsZV9tdXQucnM=) | `85.50% <ø> (ø)` | | | [iceoryx2/src/service/attribute.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/245?src=pr&el=tree&filepath=iceoryx2%2Fsrc%2Fservice%2Fattribute.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDIvc3JjL3NlcnZpY2UvYXR0cmlidXRlLnJz) | `84.81% <ø> (ø)` | | | ... and [19 more](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/245?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) | | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/245/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx)