eclipse-iceoryx / iceoryx2

Eclipse iceoryx2™ - true zero-copy inter-process-communication in pure Rust
https://iceoryx.io
Apache License 2.0
1.03k stars 40 forks source link

[#3] Add cargo as dependency #344

Closed elfenpiff closed 3 months ago

elfenpiff commented 3 months ago

Notes for Reviewer

Pre-Review Checklist for the PR Author

  1. [ ] Add sensible notes for the reviewer
  2. [ ] PR title is short, expressive and meaningful
  3. [ ] Relevant issues are linked in the References section
  4. [ ] Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  5. [ ] Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  6. [ ] Commits messages are according to this guideline
    • [ ] Commit messages have the issue ID ([#123] Add posix ipc example)
    • [ ] Commit author matches Eclipse Contributor Agreement (and ECA is signed)
  7. [ ] Tests follow the best practice for testing
  8. [ ] Changelog updated in the unreleased section including API breaking changes
  9. [ ] Assign PR to reviewer
  10. [ ] All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

Post-review Checklist for the PR Author

  1. [ ] All open points are addressed and tracked via issues

References

Closes #

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 80.44%. Comparing base (67aefe3) to head (8025452).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/344/graphs/tree.svg?width=650&height=150&src=pr&token=FN3YFXTJCI&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx)](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/344?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) ```diff @@ Coverage Diff @@ ## main #344 +/- ## ========================================== - Coverage 80.45% 80.44% -0.02% ========================================== Files 192 192 Lines 22495 22495 ========================================== - Hits 18099 18096 -3 - Misses 4396 4399 +3 ``` [see 6 files with indirect coverage changes](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/344/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx)
elBoberido commented 3 months ago

I also tried this on friday and reverted it since it didn't work. It's also weird that there is no bug report in the repo of the action. Either everybody waits for anyone else to report the bug or we are for some reasons the only ones experiencing it.

elBoberido commented 3 months ago

fixed in #341