eclipse-iceoryx / iceoryx2

Eclipse iceoryx2™ - true zero-copy inter-process-communication in pure Rust
https://iceoryx.io
Apache License 2.0
1.04k stars 40 forks source link

[#345] Add node debug details #346

Closed elfenpiff closed 3 months ago

elfenpiff commented 3 months ago

Notes for Reviewer

Pre-Review Checklist for the PR Author

  1. [x] Add sensible notes for the reviewer
  2. [x] PR title is short, expressive and meaningful
  3. [x] Relevant issues are linked in the References section
  4. [x] Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  5. [x] Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  6. [x] Commits messages are according to this guideline
    • [x] Commit messages have the issue ID ([#123] Add posix ipc example)
    • [x] Commit author matches Eclipse Contributor Agreement (and ECA is signed)
  7. [x] Tests follow the best practice for testing
  8. [x] Changelog updated in the unreleased section including API breaking changes
  9. [x] Assign PR to reviewer
  10. [x] All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

Post-review Checklist for the PR Author

  1. [x] All open points are addressed and tracked via issues

References

Closes #345

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 56.25000% with 21 lines in your changes missing coverage. Please review.

Project coverage is 80.41%. Comparing base (d9024b7) to head (aebccb9).

Files Patch % Lines
iceoryx2/src/node/mod.rs 40.74% 16 Missing :warning:
iceoryx2-bb/posix/src/process.rs 73.33% 4 Missing :warning:
iceoryx2-pal/posix/src/linux/unistd.rs 83.33% 1 Missing :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/346/graphs/tree.svg?width=650&height=150&src=pr&token=FN3YFXTJCI&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx)](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/346?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) ```diff @@ Coverage Diff @@ ## main #346 +/- ## ========================================== - Coverage 80.43% 80.41% -0.02% ========================================== Files 192 192 Lines 22495 22537 +42 ========================================== + Hits 18094 18124 +30 - Misses 4401 4413 +12 ``` | [Files](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/346?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) | Coverage Δ | | |---|---|---| | [iceoryx2-pal/posix/src/linux/unistd.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/346?src=pr&el=tree&filepath=iceoryx2-pal%2Fposix%2Fsrc%2Flinux%2Funistd.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDItcGFsL3Bvc2l4L3NyYy9saW51eC91bmlzdGQucnM=) | `82.45% <83.33%> (+0.10%)` | :arrow_up: | | [iceoryx2-bb/posix/src/process.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/346?src=pr&el=tree&filepath=iceoryx2-bb%2Fposix%2Fsrc%2Fprocess.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDItYmIvcG9zaXgvc3JjL3Byb2Nlc3MucnM=) | `43.58% <73.33%> (+4.37%)` | :arrow_up: | | [iceoryx2/src/node/mod.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/346?src=pr&el=tree&filepath=iceoryx2%2Fsrc%2Fnode%2Fmod.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDIvc3JjL25vZGUvbW9kLnJz) | `70.84% <40.74%> (-1.74%)` | :arrow_down: | ... and [4 files with indirect coverage changes](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/346/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx)