search

eclipse-iceoryx / iceoryx2

Eclipse iceoryx2™ - true zero-copy inter-process-communication in pure Rust
https://iceoryx.io
Apache License 2.0
1.04k stars 40 forks source link

[#294] Introduce ServiceId #359

Closed elfenpiff closed 2 months ago

elfenpiff commented 3 months ago

Notes for Reviewer

Pre-Review Checklist for the PR Author

  1. [x] Add sensible notes for the reviewer
  2. [x] PR title is short, expressive and meaningful
  3. [x] Relevant issues are linked in the References section
  4. [x] Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  5. [x] Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  6. [x] Commits messages are according to this guideline
    • [x] Commit messages have the issue ID ([#123] Add posix ipc example)
    • [x] Commit author matches Eclipse Contributor Agreement (and ECA is signed)
  7. [x] Tests follow the best practice for testing
  8. [x] Changelog updated in the unreleased section including API breaking changes
  9. [x] Assign PR to reviewer
  10. [x] All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

Post-review Checklist for the PR Author

  1. [x] All open points are addressed and tracked via issues

References

Closes #294

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 68.66359% with 68 lines in your changes missing coverage. Please review.

Project coverage is 80.15%. Comparing base (a3b6a72) to head (f25cc5c). Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
iceoryx2-bb/system-types/src/file_name.rs 57.03% 58 Missing :warning:
iceoryx2/src/service/service_id.rs 75.00% 5 Missing :warning:
iceoryx2/src/node/mod.rs 83.33% 4 Missing :warning:
iceoryx2/src/service/builder/mod.rs 88.88% 1 Missing :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/359/graphs/tree.svg?width=650&height=150&src=pr&token=FN3YFXTJCI&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx)](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/359?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) ```diff @@ Coverage Diff @@ ## main #359 +/- ## ========================================== - Coverage 80.30% 80.15% -0.16% ========================================== Files 192 193 +1 Lines 22569 22702 +133 ========================================== + Hits 18125 18197 +72 - Misses 4444 4505 +61 ``` | [Files with missing lines](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/359?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) | Coverage Δ | | |---|---|---| | [iceoryx2/src/service/mod.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/359?src=pr&el=tree&filepath=iceoryx2%2Fsrc%2Fservice%2Fmod.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDIvc3JjL3NlcnZpY2UvbW9kLnJz) | `80.53% <100.00%> (-0.30%)` | :arrow_down: | | [iceoryx2/src/service/naming\_scheme.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/359?src=pr&el=tree&filepath=iceoryx2%2Fsrc%2Fservice%2Fnaming_scheme.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDIvc3JjL3NlcnZpY2UvbmFtaW5nX3NjaGVtZS5ycw==) | `100.00% <ø> (ø)` | | | [iceoryx2/src/service/port\_factory/event.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/359?src=pr&el=tree&filepath=iceoryx2%2Fsrc%2Fservice%2Fport_factory%2Fevent.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDIvc3JjL3NlcnZpY2UvcG9ydF9mYWN0b3J5L2V2ZW50LnJz) | `100.00% <100.00%> (ø)` | | | [iceoryx2/src/service/port\_factory/mod.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/359?src=pr&el=tree&filepath=iceoryx2%2Fsrc%2Fservice%2Fport_factory%2Fmod.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDIvc3JjL3NlcnZpY2UvcG9ydF9mYWN0b3J5L21vZC5ycw==) | `80.00% <ø> (ø)` | | | [...ryx2/src/service/port\_factory/publish\_subscribe.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/359?src=pr&el=tree&filepath=iceoryx2%2Fsrc%2Fservice%2Fport_factory%2Fpublish_subscribe.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDIvc3JjL3NlcnZpY2UvcG9ydF9mYWN0b3J5L3B1Ymxpc2hfc3Vic2NyaWJlLnJz) | `100.00% <100.00%> (ø)` | | | [iceoryx2/src/service/static\_config/mod.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/359?src=pr&el=tree&filepath=iceoryx2%2Fsrc%2Fservice%2Fstatic_config%2Fmod.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDIvc3JjL3NlcnZpY2Uvc3RhdGljX2NvbmZpZy9tb2QucnM=) | `86.41% <100.00%> (-0.64%)` | :arrow_down: | | [iceoryx2/src/service/builder/mod.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/359?src=pr&el=tree&filepath=iceoryx2%2Fsrc%2Fservice%2Fbuilder%2Fmod.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDIvc3JjL3NlcnZpY2UvYnVpbGRlci9tb2QucnM=) | `78.87% <88.88%> (-0.67%)` | :arrow_down: | | [iceoryx2/src/node/mod.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/359?src=pr&el=tree&filepath=iceoryx2%2Fsrc%2Fnode%2Fmod.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDIvc3JjL25vZGUvbW9kLnJz) | `70.92% <83.33%> (+0.07%)` | :arrow_up: | | [iceoryx2/src/service/service\_id.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/359?src=pr&el=tree&filepath=iceoryx2%2Fsrc%2Fservice%2Fservice_id.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDIvc3JjL3NlcnZpY2Uvc2VydmljZV9pZC5ycw==) | `75.00% <75.00%> (ø)` | | | [iceoryx2-bb/system-types/src/file\_name.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/359?src=pr&el=tree&filepath=iceoryx2-bb%2Fsystem-types%2Fsrc%2Ffile_name.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDItYmIvc3lzdGVtLXR5cGVzL3NyYy9maWxlX25hbWUucnM=) | `56.66% <57.03%> (-12.90%)` | :arrow_down: | ... and [5 files with indirect coverage changes](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/359/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx)