Closed orecham closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 79.43%. Comparing base (
2d1f01d
) to head (02fee0d
). Report is 24 commits behind head on main.
@orecham nice work! Could you add please the following features:
iox2 service list:
output is sorted by service name
you add the the messaging pattern in front of the service like [event] MyServiceName
or [publish-subscribe] MyServiceName
. Maybe with spaces in between [event]
and the service name so that every name aligns in the same column.
iox2 service details MyServiceName
if there are two services running with the same name but different messaging pattern then it shows only the publish-subscribe version of it
Can you please add readme into iceoryx2-cli/README.md
and describe there quickly how to use the cli. I tried cargo run --bin iox2 -- services list
and it failed by stating that services was unknown. I could use it with cargo run --bin iox2-services -- list
but I think this is not the intended use.
@orecham nice work! Could you add please the following features:
iox2 service list:
- output is sorted by service name
- you add the the messaging pattern in front of the service like
[event] MyServiceName
or[publish-subscribe] MyServiceName
. Maybe with spaces in between[event]
and the service name so that every name aligns in the same column.
iox2 service details MyServiceName
- if there are two services running with the same name but different messaging pattern then it shows only the publish-subscribe version of it
- Can you please add readme into
iceoryx2-cli/README.md
and describe there quickly how to use the cli. I triedcargo run --bin iox2 -- services list
and it failed by stating that services was unknown. I could use it withcargo run --bin iox2-services -- list
but I think this is not the intended use.
@elfenpiff I have overhauled the implementation to address the findings:
iceoryx2
crate have been revertediceoryx2
structs but instead extracts only the relevant details that make sense for the cli commandiox2-services details
now prints details for all services matching the name
iox2
entrypointservices
-> services-debug
iox2
maps to these using iox2 --list
debug
and release
builds with the same name and my time box to work on this has run out
@elfenpiff Note there are some tweaks to the implementation here: https://github.com/eclipse-iceoryx/iceoryx2/pull/380/commits/0e109d3460988dff1c59de35d8d72d134541d10f
Mainly:
iox2 services list
by messaging pattern@elfenpiff Release notes added here: https://github.com/eclipse-iceoryx/iceoryx2/pull/379/commits/1512f6f833423b6f5380ae0fd445420b89c97726
Notes for Reviewer
iox2 services list
andiox2 services details
RON
but can be switched toJSON
orYAML
using a CLI optionserde
iox2-services
```bash $ iox2 services --help Query information about iceoryx2 services Usage: iox2-services [OPTIONS] [COMMAND] Options: -f, --formatiox2-services list
```bash $ iox2 services list --help List all existing services Usage: iox2-services list [OPTIONS] Options: -f, --formatiox2-services details
```bash $ iox2 services details --help Show details of an existing service Usage: iox2-services details [OPTIONS]Pre-Review Checklist for the PR Author
SPDX-License-Identifier: Apache-2.0 OR MIT
iox2-123-introduce-posix-ipc-example
)[#123] Add posix ipc example
)Tests follow the best practice for testingtask-list-completed
)Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References
Relates #98