Closed elfenpiff closed 1 month ago
Attention: Patch coverage is 78.82353%
with 18 lines
in your changes missing coverage. Please review.
Project coverage is 79.00%. Comparing base (
88d7507
) to head (dbff454
). Report is 10 commits behind head on main.
Files with missing lines | Patch % | Lines |
---|---|---|
iceoryx2/src/sample_mut_uninit.rs | 74.64% | 18 Missing :warning: |
Notes for Reviewer
SampleMutUninit
struct that does not offer asend
methodsend_sample
intosend
since it was weird to readsend_sample(std::move(sample))
, this is much cleanersend(std::move(sample))
.SampleMut
has no C binding, the C++ implementation is done directly via the C API, otherwise it would be much more code on the FFI layerPre-Review Checklist for the PR Author
SPDX-License-Identifier: Apache-2.0 OR MIT
iox2-123-introduce-posix-ipc-example
)[#123] Add posix ipc example
)task-list-completed
)Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References
Closes #394