search

eclipse-iceoryx / iceoryx2

Eclipse iceoryx2™ - true zero-copy inter-process-communication in pure Rust
https://iceoryx.io
Apache License 2.0
1.03k stars 40 forks source link

[#390] waitset #424

Closed elfenpiff closed 1 month ago

elfenpiff commented 1 month ago

Notes for Reviewer

Pre-Review Checklist for the PR Author

  1. [x] Add sensible notes for the reviewer
  2. [x] PR title is short, expressive and meaningful
  3. [x] Relevant issues are linked in the References section
  4. [x] Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  5. [x] Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  6. [x] Commits messages are according to this guideline
    • [x] Commit messages have the issue ID ([#123] Add posix ipc example)
    • [x] Commit author matches Eclipse Contributor Agreement (and ECA is signed)
  7. [x] Tests follow the best practice for testing
  8. [x] Changelog updated in the unreleased section including API breaking changes
  9. [x] Assign PR to reviewer
  10. [x] All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

Post-review Checklist for the PR Author

  1. [x] All open points are addressed and tracked via issues

References

Relates to #390

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 80.77601% with 109 lines in your changes missing coverage. Please review.

Project coverage is 79.00%. Comparing base (6f05b7b) to head (5904a48). Report is 41 commits behind head on main.

Files with missing lines Patch % Lines
iceoryx2/src/port/waitset.rs 78.98% 66 Missing :warning:
iceoryx2-bb/posix/src/deadline_queue.rs 89.65% 15 Missing :warning:
iceoryx2-cal/src/reactor/posix_select.rs 75.00% 13 Missing :warning:
iceoryx2/src/node/mod.rs 0.00% 12 Missing :warning:
iceoryx2-bb/posix/src/file_descriptor_set.rs 91.66% 3 Missing :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/424/graphs/tree.svg?width=650&height=150&src=pr&token=FN3YFXTJCI&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx)](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/424?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) ```diff @@ Coverage Diff @@ ## main #424 +/- ## ========================================== + Coverage 78.97% 79.00% +0.03% ========================================== Files 195 196 +1 Lines 22836 23251 +415 ========================================== + Hits 18034 18369 +335 - Misses 4802 4882 +80 ``` | [Files with missing lines](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/424?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) | Coverage Δ | | |---|---|---| | [iceoryx2-bb/posix/src/clock.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/424?src=pr&el=tree&filepath=iceoryx2-bb%2Fposix%2Fsrc%2Fclock.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDItYmIvcG9zaXgvc3JjL2Nsb2NrLnJz) | `85.71% <100.00%> (+0.31%)` | :arrow_up: | | [iceoryx2-bb/posix/src/udp\_socket.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/424?src=pr&el=tree&filepath=iceoryx2-bb%2Fposix%2Fsrc%2Fudp_socket.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDItYmIvcG9zaXgvc3JjL3VkcF9zb2NrZXQucnM=) | `73.89% <100.00%> (ø)` | | | [iceoryx2/src/port/listener.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/424?src=pr&el=tree&filepath=iceoryx2%2Fsrc%2Fport%2Flistener.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDIvc3JjL3BvcnQvbGlzdGVuZXIucnM=) | `91.42% <100.00%> (+0.25%)` | :arrow_up: | | [iceoryx2/src/port/mod.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/424?src=pr&el=tree&filepath=iceoryx2%2Fsrc%2Fport%2Fmod.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDIvc3JjL3BvcnQvbW9kLnJz) | `0.00% <ø> (ø)` | | | [iceoryx2/src/service/ipc.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/424?src=pr&el=tree&filepath=iceoryx2%2Fsrc%2Fservice%2Fipc.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDIvc3JjL3NlcnZpY2UvaXBjLnJz) | `100.00% <ø> (ø)` | | | [iceoryx2/src/service/local.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/424?src=pr&el=tree&filepath=iceoryx2%2Fsrc%2Fservice%2Flocal.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDIvc3JjL3NlcnZpY2UvbG9jYWwucnM=) | `100.00% <ø> (ø)` | | | [iceoryx2/src/service/mod.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/424?src=pr&el=tree&filepath=iceoryx2%2Fsrc%2Fservice%2Fmod.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDIvc3JjL3NlcnZpY2UvbW9kLnJz) | `78.34% <ø> (ø)` | | | [iceoryx2-bb/posix/src/file\_descriptor\_set.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/424?src=pr&el=tree&filepath=iceoryx2-bb%2Fposix%2Fsrc%2Ffile_descriptor_set.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDItYmIvcG9zaXgvc3JjL2ZpbGVfZGVzY3JpcHRvcl9zZXQucnM=) | `91.92% <91.66%> (+1.14%)` | :arrow_up: | | [iceoryx2/src/node/mod.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/424?src=pr&el=tree&filepath=iceoryx2%2Fsrc%2Fnode%2Fmod.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDIvc3JjL25vZGUvbW9kLnJz) | `68.83% <0.00%> (-2.17%)` | :arrow_down: | | [iceoryx2-cal/src/reactor/posix\_select.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/424?src=pr&el=tree&filepath=iceoryx2-cal%2Fsrc%2Freactor%2Fposix_select.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDItY2FsL3NyYy9yZWFjdG9yL3Bvc2l4X3NlbGVjdC5ycw==) | `81.55% <75.00%> (+2.98%)` | :arrow_up: | | ... and [2 more](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/424?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) | | ... and [5 files with indirect coverage changes](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/424/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx)