eclipse-iceoryx / iceoryx2

Eclipse iceoryx2™ - true zero-copy inter-process-communication in pure Rust
https://iceoryx.io
Apache License 2.0
1.03k stars 40 forks source link

[#213] test public API open_or_create_with_attributes #427

Closed xieyuschen closed 1 month ago

xieyuschen commented 1 month ago

Notes for Reviewer

Pre-Review Checklist for the PR Author

  1. [X] Add sensible notes for the reviewer
  2. [X] PR title is short, expressive and meaningful
  3. [X] Relevant issues are linked in the References section
  4. [X] Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  5. [X] Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  6. [X] Commits messages are according to this guideline
    • [X] Commit messages have the issue ID ([#123] Add posix ipc example)
    • [X] Commit author matches Eclipse Contributor Agreement (and ECA is signed)
  7. [X] Tests follow the best practice for testing
  8. [X] Changelog updated in the unreleased section including API breaking changes
  9. [x] Assign PR to reviewer
  10. [X] All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

Post-review Checklist for the PR Author

  1. [x] All open points are addressed and tracked via issues

References

Relates to #213

elfenpiff commented 1 month ago

@xieyuschen you forget to add the Relates to #213 at the end of the PR description - I added it for you!

xieyuschen commented 1 month ago

Thank you very much for your contribution. As soon as the CI is green we merge it. I think you need to format the code.

my bad, I have forgot to add the fmt into my git hooks. i have amended the commit and pushed it. thanks a lot.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.94%. Comparing base (aec86ae) to head (26d2532). Report is 2 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/427/graphs/tree.svg?width=650&height=150&src=pr&token=FN3YFXTJCI&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx)](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/427?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) ```diff @@ Coverage Diff @@ ## main #427 +/- ## ========================================== - Coverage 78.97% 78.94% -0.03% ========================================== Files 194 194 Lines 22730 22730 ========================================== - Hits 17951 17945 -6 - Misses 4779 4785 +6 ``` | [Files with missing lines](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/427?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) | Coverage Δ | | |---|---|---| | [iceoryx2/src/service/builder/publish\_subscribe.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/427?src=pr&el=tree&filepath=iceoryx2%2Fsrc%2Fservice%2Fbuilder%2Fpublish_subscribe.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDIvc3JjL3NlcnZpY2UvYnVpbGRlci9wdWJsaXNoX3N1YnNjcmliZS5ycw==) | `90.97% <ø> (+2.81%)` | :arrow_up: | ... and [4 files with indirect coverage changes](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/427/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx)
xieyuschen commented 1 month ago

@elfenpiff , could you kindly help to re-run the failed pipeline? Only windows failed and irrelevant to the current PR. I don't have permission to re-run the failure ci and trigger the whole pipeline takes more time.

--- STDOUT:              iceoryx2-bb-threadsafe::trigger_queue_tests trigger_queue_one_pop_notifies_exactly_one_timed_push ---

running 1 test
test trigger_queue_one_pop_notifies_exactly_one_timed_push ... FAILED

failures:

failures:
    trigger_queue_one_pop_notifies_exactly_one_timed_push

test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 11 filtered out; finished in 0.20s

--- STDERR:              iceoryx2-bb-threadsafe::trigger_queue_tests trigger_queue_one_pop_notifies_exactly_one_timed_push ---
thread '<unnamed>' panicked at iceoryx2-bb\threadsafe\tests\trigger_queue_tests.rs:267:17:
assertion failed: expr: sut.timed_push(0, TIMEOUT * 1000) == true;  value: false == true
stack backtrace:
elfenpiff commented 1 month ago

could you kindly help to re-run the failed pipeline?

@xieyuschen done.

and its merge. Congratulations on your first of hopefully many contributions!

xieyuschen commented 1 month ago

could you kindly help to re-run the failed pipeline?

@xieyuschen done.

and its merge. Congratulations on your first of hopefully many contributions!

Cool, it's an interesting project and actually it's helpful to eliminate massive ser/desel cpu resources under company scope. I have thought it in golang before but haven't chosen this approach because of the challenges in golang and the corresponding maintenance inside a company. This time in an open source project I believe I can participate more:) Thanks for your patience to review.

elBoberido commented 1 month ago

@xieyuschen if you are interested in golang, there is #225. If you want, I think you could ask in the issue if help is wanted.