Closed xieyuschen closed 1 month ago
@xieyuschen you forget to add the Relates to #213 at the end of the PR description - I added it for you!
Thank you very much for your contribution. As soon as the CI is green we merge it. I think you need to format the code.
my bad, I have forgot to add the fmt
into my git hooks. i have amended the commit and pushed it. thanks a lot.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 78.94%. Comparing base (
aec86ae
) to head (26d2532
). Report is 2 commits behind head on main.
@elfenpiff , could you kindly help to re-run the failed pipeline? Only windows failed and irrelevant to the current PR. I don't have permission to re-run the failure ci and trigger the whole pipeline takes more time.
--- STDOUT: iceoryx2-bb-threadsafe::trigger_queue_tests trigger_queue_one_pop_notifies_exactly_one_timed_push ---
running 1 test
test trigger_queue_one_pop_notifies_exactly_one_timed_push ... FAILED
failures:
failures:
trigger_queue_one_pop_notifies_exactly_one_timed_push
test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 11 filtered out; finished in 0.20s
--- STDERR: iceoryx2-bb-threadsafe::trigger_queue_tests trigger_queue_one_pop_notifies_exactly_one_timed_push ---
thread '<unnamed>' panicked at iceoryx2-bb\threadsafe\tests\trigger_queue_tests.rs:267:17:
assertion failed: expr: sut.timed_push(0, TIMEOUT * 1000) == true; value: false == true
stack backtrace:
could you kindly help to re-run the failed pipeline?
@xieyuschen done.
and its merge. Congratulations on your first of hopefully many contributions!
could you kindly help to re-run the failed pipeline?
@xieyuschen done.
and its merge. Congratulations on your first of hopefully many contributions!
Cool, it's an interesting project and actually it's helpful to eliminate massive ser/desel cpu resources under company scope. I have thought it in golang before but haven't chosen this approach because of the challenges in golang and the corresponding maintenance inside a company. This time in an open source project I believe I can participate more:) Thanks for your patience to review.
@xieyuschen if you are interested in golang, there is #225. If you want, I think you could ask in the issue if help is wanted.
Notes for Reviewer
open_or_create_with_attributes
should be tested.Pre-Review Checklist for the PR Author
SPDX-License-Identifier: Apache-2.0 OR MIT
iox2-123-introduce-posix-ipc-example
)[#123] Add posix ipc example
)task-list-completed
)Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References
Relates to #213