Closed xieyuschen closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 79.02%. Comparing base (
a7f0df7
) to head (c472781
). Report is 3 commits behind head on main.
oops, I have found that alignment in 32bits is 4, not 8. let me change it:)
@xieyuschen It is always a pleasure to start the week with an Earl Grey Hot (with milk) and a review of your PR.
Thank you very much for your continuous effort and helping us out!
ack, will try to resolve it later today and thanks for your clarify.
Hi @elfenpiff , I have updated the PR with multiple small commits for you to check them based on your comments. I resolved the straitfoward comments and left some comments for you to see whether you have concerns about it.
Thanks for reviewing.
Hi @elfenpiff , I have squashed the commits together for your final review. Could you review it and then we can merge it?
I plan to create another new PRs for the testing later. I found it helps me to understand the project while improving our codebase as well.
@xieyuschen fix the little CI failure with size_of
and we can get it merged.
@xieyuschen fix the little CI failure with
size_of
and we can get it merged.
sure, i haven't encountered it in my local so i have missed it. but nvm, now it should be fine:)
Notes for Reviewer
I have added some test cases during I'm learning the codes. It improves out test.
Pre-Review Checklist for the PR Author
SPDX-License-Identifier: Apache-2.0 OR MIT
iox2-123-introduce-posix-ipc-example
)[#123] Add posix ipc example
)task-list-completed
)Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References
Updates #213