Closed elfenpiff closed 1 month ago
Attention: Patch coverage is 52.77778%
with 17 lines
in your changes missing coverage. Please review.
Project coverage is 78.93%. Comparing base (
e9332a0
) to head (9ebf521
). Report is 6 commits behind head on main.
Files with missing lines | Patch % | Lines |
---|---|---|
iceoryx2-bb/posix/src/signal.rs | 52.77% | 17 Missing :warning: |
Notes for Reviewer
The
SignalHandler
registers in the beginning every signal to keep track of them so that the user can later acquire them via an internal atomic variable. The problem is, that by default it also registersSIGSEGV
and other fatal signals. If such a signal is emitted in turns into an infinite loop where the signal callback is called.This can be mitigated by splitting up the FetchableSignals into FatalFetchableSignals (e.g.
SIGSEGV
, ...) and NonFatalFetchableSignals (SIGINT
,SIGUSR1
... ). Certain operations are only allowed for NonFatalFetchableSignals, like acquiring the last signal that was emitted. Also the SignalHandler only registers NonFatalFetchableSignals by default so that the user can later acquire the signal that was emitted. For FatalFetchableSignals it would not make sense since then the callback of the signal is the last thing the program executes.Pre-Review Checklist for the PR Author
SPDX-License-Identifier: Apache-2.0 OR MIT
iox2-123-introduce-posix-ipc-example
)[#123] Add posix ipc example
)task-list-completed
)Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References
Relates to #436