Closed xieyuschen closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 79.18%. Comparing base (
ca22976
) to head (88aba3d
). Report is 4 commits behind head on main.
@elfenpiff @elBoberido i don't have the permission to assign the reviewer:( so at you directly
Just split the one test case up into several ones and we are good to merge!
cheers! @elfenpiff
@xieyuschen Could you add [#213]
to the commit message split the big test_is_compatible_to into small tests
Not sure why the preflight-check didn't catch this 🤔
@xieyuschen Could you add
[#213]
to the commit messagesplit the big test_is_compatible_to into small tests
Not sure why the preflight-check didn't catch this 🤔
done, thanks for reminding.
added on at 21:29: not sure why the pipeline failed so gamend and pushed it again to make the pipeline happy.
@elfenpiff @orecham looks like the macos pipeline is a bit unstable and it failed to setup rust. The other pipelines passed.
@xieyuschen The next iceoryx community meetup is online on the 5th of November: https://github.com/eclipse-iceoryx/iceoryx/wiki/2024-11-05-Eclipse-iceoryx-developer-meetup
It would be nice to get to know you there. I know it is still a while, but you already committed some great contributions so it would be a pleasure to get to know you in person if you like. Also we could discuss if you would be interested in driving a feature from our roadmap - something that might interest you or you always wanted to try.
Great to have you on board!
@xieyuschen The next iceoryx community meetup is online on the 5th of November: https://github.com/eclipse-iceoryx/iceoryx/wiki/2024-11-05-Eclipse-iceoryx-developer-meetup
It would be nice to get to know you there. I know it is still a while, but you already committed some great contributions so it would be a pleasure to get to know you in person if you like. Also we could discuss if you would be interested in driving a feature from our roadmap - something that might interest you or you always wanted to try.
Great to have you on board!
cool, I'm looking forward to meeting you guys in the meeting and learning more about future plans.
Notes for Reviewer
Pre-Review Checklist for the PR Author
SPDX-License-Identifier: Apache-2.0 OR MIT
iox2-123-introduce-posix-ipc-example
)[#123] Add posix ipc example
)task-list-completed
)Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References
Updates #213