eclipse-iceoryx / iceoryx2

Eclipse iceoryx2™ - true zero-copy inter-process-communication in pure Rust
https://iceoryx.io
Apache License 2.0
1.03k stars 40 forks source link

[#213]: tests methods of MessageTypeDetails #455

Closed xieyuschen closed 1 month ago

xieyuschen commented 1 month ago

Notes for Reviewer

Pre-Review Checklist for the PR Author

  1. [x] Add sensible notes for the reviewer
  2. [x] PR title is short, expressive and meaningful
  3. [x] Relevant issues are linked in the References section
  4. [x] Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  5. [x] Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  6. [x] Commits messages are according to this guideline
    • [x] Commit messages have the issue ID ([#123] Add posix ipc example)
    • [] Commit author matches Eclipse Contributor Agreement (and ECA is signed)
  7. [x] Tests follow the best practice for testing
  8. [x] Changelog updated in the unreleased section including API breaking changes
  9. [x] Assign PR to reviewer
  10. [x] All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

Post-review Checklist for the PR Author

  1. [x] All open points are addressed and tracked via issues

References

Updates #213

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 79.18%. Comparing base (ca22976) to head (88aba3d). Report is 4 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/455/graphs/tree.svg?width=650&height=150&src=pr&token=FN3YFXTJCI&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx)](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/455?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) ```diff @@ Coverage Diff @@ ## main #455 +/- ## ========================================== + Coverage 78.94% 79.18% +0.23% ========================================== Files 196 196 Lines 23373 23540 +167 ========================================== + Hits 18451 18639 +188 + Misses 4922 4901 -21 ``` | [Files with missing lines](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/455?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) | Coverage Δ | | |---|---|---| | [.../src/service/static\_config/message\_type\_details.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/455?src=pr&el=tree&filepath=iceoryx2%2Fsrc%2Fservice%2Fstatic_config%2Fmessage_type_details.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDIvc3JjL3NlcnZpY2Uvc3RhdGljX2NvbmZpZy9tZXNzYWdlX3R5cGVfZGV0YWlscy5ycw==) | `100.00% <100.00%> (ø)` | | | [...yx2/src/service/static\_config/messaging\_pattern.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/455?src=pr&el=tree&filepath=iceoryx2%2Fsrc%2Fservice%2Fstatic_config%2Fmessaging_pattern.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDIvc3JjL3NlcnZpY2Uvc3RhdGljX2NvbmZpZy9tZXNzYWdpbmdfcGF0dGVybi5ycw==) | `92.30% <100.00%> (+18.39%)` | :arrow_up: | ... and [7 files with indirect coverage changes](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/455/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx)
xieyuschen commented 1 month ago

@elfenpiff @elBoberido i don't have the permission to assign the reviewer:( so at you directly

xieyuschen commented 1 month ago

Just split the one test case up into several ones and we are good to merge!

cheers! @elfenpiff

orecham commented 1 month ago

@xieyuschen Could you add [#213] to the commit message split the big test_is_compatible_to into small tests

Not sure why the preflight-check didn't catch this 🤔

xieyuschen commented 1 month ago

@xieyuschen Could you add [#213] to the commit message split the big test_is_compatible_to into small tests

Not sure why the preflight-check didn't catch this 🤔

done, thanks for reminding.

added on at 21:29: not sure why the pipeline failed so gamend and pushed it again to make the pipeline happy.

xieyuschen commented 1 month ago

@elfenpiff @orecham looks like the macos pipeline is a bit unstable and it failed to setup rust. The other pipelines passed.

elfenpiff commented 1 month ago

@xieyuschen The next iceoryx community meetup is online on the 5th of November: https://github.com/eclipse-iceoryx/iceoryx/wiki/2024-11-05-Eclipse-iceoryx-developer-meetup

It would be nice to get to know you there. I know it is still a while, but you already committed some great contributions so it would be a pleasure to get to know you in person if you like. Also we could discuss if you would be interested in driving a feature from our roadmap - something that might interest you or you always wanted to try.

Great to have you on board!

xieyuschen commented 1 month ago

@xieyuschen The next iceoryx community meetup is online on the 5th of November: https://github.com/eclipse-iceoryx/iceoryx/wiki/2024-11-05-Eclipse-iceoryx-developer-meetup

It would be nice to get to know you there. I know it is still a while, but you already committed some great contributions so it would be a pleasure to get to know you in person if you like. Also we could discuss if you would be interested in driving a feature from our roadmap - something that might interest you or you always wanted to try.

Great to have you on board!

cool, I'm looking forward to meeting you guys in the meeting and learning more about future plans.