Open zmostafa opened 1 month ago
Moreover, please follow the convention here:
[#396]: Read and set LogLevel from environment variable
@zmostafa hey hey ... you are back. I am happy to see your PR plopping up here.
@elfenpiff you have to thank Jeff for the motivation, and thanks for the nice words as expected from you.
You guys are the best :heart:
Attention: Patch coverage is 64.00000%
with 9 lines
in your changes missing coverage. Please review.
Project coverage is 79.64%. Comparing base (
810fb87
) to head (e2b323c
). Report is 9 commits behind head on main.
Files with missing lines | Patch % | Lines |
---|---|---|
iceoryx2-bb/log/src/lib.rs | 64.00% | 9 Missing :warning: |
Notes for Reviewer
Adds functionality to set the log level from the environment.
I went for @elBoberido proposal solution, where I read an environment variable called
IOX2_LOG_LEVEL
and set the LogLevel, with its value at runtime.Pre-Review Checklist for the PR Author
SPDX-License-Identifier: Apache-2.0 OR MIT
iox2-123-introduce-posix-ipc-example
)[#123] Add posix ipc example
)task-list-completed
)Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References
Closes #396