eclipse-iceoryx / iceoryx2

Eclipse iceoryx2™ - true zero-copy inter-process-communication in pure Rust
https://iceoryx.io
Apache License 2.0
1.03k stars 40 forks source link

[#349] Add remaining cargo feature flags to bazel #479

Closed elBoberido closed 1 month ago

elBoberido commented 1 month ago

Notes for Reviewer

This PR adds remaining cargo feature flags to bazel.

Additionally, it re-enables running the tests via bazel in the CI and optimizes the CI to not partially rebuild the code for tests by harmonizing the flags passed to cargo build and cargo nextest run

Due to reaching the Cirrus CI limit early this month, the Cirrus CI is deactivated and the targets are limited even further.

Finally, a FAQ for iceoryx developers was added.

Pre-Review Checklist for the PR Author

  1. [x] Add sensible notes for the reviewer
  2. [x] PR title is short, expressive and meaningful
  3. [x] Relevant issues are linked in the References section
  4. [x] Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  5. [x] Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  6. [x] Commits messages are according to this guideline
    • [x] Commit messages have the issue ID ([#123] Add posix ipc example)
    • [x] Commit author matches Eclipse Contributor Agreement (and ECA is signed)
  7. [x] Tests follow the best practice for testing
  8. [x] Changelog updated in the unreleased section including API breaking changes
  9. [x] Assign PR to reviewer
  10. [x] All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

Post-review Checklist for the PR Author

  1. [x] All open points are addressed and tracked via issues

References

Relates to #349

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.94%. Comparing base (a657228) to head (97264ae). Report is 11 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/479/graphs/tree.svg?width=650&height=150&src=pr&token=FN3YFXTJCI&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx)](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/479?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) ```diff @@ Coverage Diff @@ ## main #479 +/- ## ======================================= Coverage 78.93% 78.94% ======================================= Files 198 198 Lines 23627 23627 ======================================= + Hits 18651 18653 +2 + Misses 4976 4974 -2 ``` [see 1 file with indirect coverage changes](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/479/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx)
elBoberido commented 1 month ago

@elfenpiff @orecham it seems I was too hasty to add reviewers to the PR. I need to debug why the bazel CI does not like my changes