search

eclipse-iceoryx / iceoryx2

Eclipse iceoryx2™ - true zero-copy inter-process-communication in pure Rust
https://iceoryx.io
Apache License 2.0
1.03k stars 40 forks source link

[#349] Add all remaining tests to bazel #482

Closed elBoberido closed 1 month ago

elBoberido commented 1 month ago

Notes for Reviewer

The PR makes the remaining tests available to bazel.

Since bazel runs the tests in parallel, some of them needed to be adjusted for isolation.

Pre-Review Checklist for the PR Author

  1. [x] Add sensible notes for the reviewer
  2. [x] PR title is short, expressive and meaningful
  3. [x] Relevant issues are linked in the References section
  4. [x] Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  5. [x] Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  6. [x] Commits messages are according to this guideline
    • [x] Commit messages have the issue ID ([#123] Add posix ipc example)
    • [x] Commit author matches Eclipse Contributor Agreement (and ECA is signed)
  7. [x] Tests follow the best practice for testing
  8. [x] Changelog updated in the unreleased section including API breaking changes
  9. [x] Assign PR to reviewer
  10. [ ] All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

Post-review Checklist for the PR Author

  1. [x] All open points are addressed and tracked via issues

References

Relates to #349

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 80.64516% with 18 lines in your changes missing coverage. Please review.

Project coverage is 79.14%. Comparing base (4dc37ec) to head (55e736a). Report is 39 commits behind head on main.

Files with missing lines Patch % Lines
iceoryx2/src/testing.rs 75.00% 8 Missing :warning:
iceoryx2-bb/posix/src/testing.rs 44.44% 5 Missing :warning:
iceoryx2-cal/src/testing.rs 87.50% 5 Missing :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/482/graphs/tree.svg?width=650&height=150&src=pr&token=FN3YFXTJCI&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx)](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/482?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) ```diff @@ Coverage Diff @@ ## main #482 +/- ## ========================================== + Coverage 78.92% 79.14% +0.22% ========================================== Files 198 200 +2 Lines 23627 23716 +89 ========================================== + Hits 18647 18771 +124 + Misses 4980 4945 -35 ``` | [Files with missing lines](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/482?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) | Coverage Δ | | |---|---|---| | [iceoryx2-bb/testing/src/lifetime\_tracker.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/482?src=pr&el=tree&filepath=iceoryx2-bb%2Ftesting%2Fsrc%2Flifetime_tracker.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDItYmIvdGVzdGluZy9zcmMvbGlmZXRpbWVfdHJhY2tlci5ycw==) | `88.00% <100.00%> (+2.28%)` | :arrow_up: | | [...l/src/communication\_channel/posix\_shared\_memory.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/482?src=pr&el=tree&filepath=iceoryx2-cal%2Fsrc%2Fcommunication_channel%2Fposix_shared_memory.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDItY2FsL3NyYy9jb21tdW5pY2F0aW9uX2NoYW5uZWwvcG9zaXhfc2hhcmVkX21lbW9yeS5ycw==) | `90.64% <100.00%> (+7.11%)` | :arrow_up: | | [iceoryx2-cal/src/event/unix\_datagram\_socket.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/482?src=pr&el=tree&filepath=iceoryx2-cal%2Fsrc%2Fevent%2Funix_datagram_socket.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDItY2FsL3NyYy9ldmVudC91bml4X2RhdGFncmFtX3NvY2tldC5ycw==) | `87.66% <100.00%> (+1.05%)` | :arrow_up: | | [iceoryx2-cal/src/named\_concept.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/482?src=pr&el=tree&filepath=iceoryx2-cal%2Fsrc%2Fnamed_concept.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDItY2FsL3NyYy9uYW1lZF9jb25jZXB0LnJz) | `76.19% <ø> (ø)` | | | [iceoryx2-bb/posix/src/testing.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/482?src=pr&el=tree&filepath=iceoryx2-bb%2Fposix%2Fsrc%2Ftesting.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDItYmIvcG9zaXgvc3JjL3Rlc3RpbmcucnM=) | `58.33% <44.44%> (-41.67%)` | :arrow_down: | | [iceoryx2-cal/src/testing.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/482?src=pr&el=tree&filepath=iceoryx2-cal%2Fsrc%2Ftesting.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDItY2FsL3NyYy90ZXN0aW5nLnJz) | `87.50% <87.50%> (ø)` | | | [iceoryx2/src/testing.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/482?src=pr&el=tree&filepath=iceoryx2%2Fsrc%2Ftesting.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDIvc3JjL3Rlc3RpbmcucnM=) | `75.00% <75.00%> (ø)` | | ... and [14 files with indirect coverage changes](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/482/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx)
elBoberido commented 1 month ago

@elfenpiff the nightly toolchain was updated and now the thread exit tests are failing on the unstable builds