eclipse-iceoryx / iceoryx2

Eclipse iceoryx2™ - true zero-copy inter-process-communication in pure Rust
https://iceoryx.io
Apache License 2.0
1.03k stars 40 forks source link

[#500] Expose UniquePortId bytes in CXX API #501

Closed orecham closed 2 days ago

orecham commented 2 weeks ago

Notes for Reviewer

Provides an API to access the bytes representing a UniquePortId from the CXX API.

Pre-Review Checklist for the PR Author

  1. [x] Add sensible notes for the reviewer
  2. [x] PR title is short, expressive and meaningful
  3. [x] Relevant issues are linked in the References section
  4. [x] Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  5. [x] Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  6. [x] Commits messages are according to this guideline
    • [x] Commit messages have the issue ID ([#123] Add posix ipc example)
    • [x] Commit author matches Eclipse Contributor Agreement (and ECA is signed)
  7. [x] Tests follow the best practice for testing
  8. [x] Changelog updated in the unreleased section including API breaking changes
  9. [x] Assign PR to reviewer
  10. [x] All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

Post-review Checklist for the PR Author

  1. [x] All open points are addressed and tracked via issues

References

Closes #500

orecham commented 2 weeks ago

@elBoberido @elfenpiff

I implemented the API for UniquePublisherId but want to get some feedback before implementing it for the rest. What do you guys think of this approach?

EDIT: I went ahead and implemented a rest to unblock myself. Let me know if you see a better way though.

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 79.06%. Comparing base (f2a948b) to head (55519ac). Report is 28 commits behind head on main.

Files with missing lines Patch % Lines
iceoryx2/src/port/port_identifiers.rs 0.00% 3 Missing :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/501/graphs/tree.svg?width=650&height=150&src=pr&token=FN3YFXTJCI&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx)](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/501?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) ```diff @@ Coverage Diff @@ ## main #501 +/- ## ========================================== - Coverage 79.31% 79.06% -0.26% ========================================== Files 200 201 +1 Lines 23757 24142 +385 ========================================== + Hits 18843 19088 +245 - Misses 4914 5054 +140 ``` | [Files with missing lines](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/501?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) | Coverage Δ | | |---|---|---| | [iceoryx2/src/port/port\_identifiers.rs](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/501?src=pr&el=tree&filepath=iceoryx2%2Fsrc%2Fport%2Fport_identifiers.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx#diff-aWNlb3J5eDIvc3JjL3BvcnQvcG9ydF9pZGVudGlmaWVycy5ycw==) | `63.63% <0.00%> (-23.87%)` | :arrow_down: | ... and [18 files with indirect coverage changes](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/501/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx)

🚨 Try these New Features:

orecham commented 2 weeks ago

@elfenpiff @elBoberido Could you take a look at this