Closed elfenpiff closed 1 week ago
Attention: Patch coverage is 80.00000%
with 8 lines
in your changes missing coverage. Please review.
Project coverage is 79.29%. Comparing base (
5f6a0dc
) to head (71c4db4
). Report is 47 commits behind head on main.
Files with missing lines | Patch % | Lines |
---|---|---|
iceoryx2/src/port/waitset.rs | 78.94% | 8 Missing :warning: |
Notes for Reviewer
DeadlineQueue::missed_deadlines()
callback needs to returnCallbackProgression
so that the user is able to stop handling missed deadlines when required.WaitSet::try_wait_and_process
was renamed toWaitSet::wait_and_process_once
since the function was actually blocking in contrast what the name suggested with thetry_
prefixWaitSet::wait_and_process
andWaitSet::wait_and_process_once
callbacks need to returnCallbackProgression
to terminate event handling whenever required - this replaces the buggyWaitSet::stop()
call.Pre-Review Checklist for the PR Author
SPDX-License-Identifier: Apache-2.0 OR MIT
iox2-123-introduce-posix-ipc-example
)[#123] Add posix ipc example
)task-list-completed
)Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References
Closes #507