[#490] bugfix in cxx slice api

[orecham]

Notes for Reviewer

1. Proper pointer const-ness when returning ImmutableSlice in non-mut payload() method

Pre-Review Checklist for the PR Author

1. [x] Add sensible notes for the reviewer
2. [x] PR title is short, expressive and meaningful
3. [x] Relevant issues are linked in the References section
4. [x] Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
5. [x] Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
6. [x] Commits messages are according to this guideline
   • [x] Commit messages have the issue ID ([#123] Add posix ipc example)
   • [x] Commit author matches Eclipse Contributor Agreement (and ECA is signed)
7. [x] Tests follow the best practice for testing
8. [x] Changelog updated in the unreleased section including API breaking changes
9. [x] Assign PR to reviewer
10. [x] All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

• [x] Commits are properly organized and messages are according to the guideline
• [x] Unit tests have been written for new behavior
• [x] Public API is documented
• [x] PR title describes the changes

Post-review Checklist for the PR Author

1. [x] All open points are addressed and tracked via issues

References

Relates to #490

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 79.28%. Comparing base (5b8e6ee) to head (2bc9bf0). Report is 3 commits behind head on main.

Additional details and impacted files

[](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/514?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx) ```diff @@ Coverage Diff @@ ## main #514 +/- ## ========================================== - Coverage 79.32% 79.28% -0.05% ========================================== Files 200 200 Lines 23757 23757 ========================================== - Hits 18845 18835 -10 - Misses 4912 4922 +10 ``` [see 6 files with indirect coverage changes](https://app.codecov.io/gh/eclipse-iceoryx/iceoryx2/pull/514/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=eclipse-iceoryx)