search

eclipse-jdt / .github

0 stars 5 forks source link

Set up Contributor Configuration #6

Closed tsmaeder closed 9 months ago

tsmaeder commented 2 years ago

We can help contributors by providing certain files like

vogella commented 2 years ago

GH build actions would also be helpful to have faster build verification (as Github actions are currently relative fast compared to Jenkins). See https://github.com/eclipse-platform/eclipse.platform.resources/blob/master/.github/workflows/maven.yml for an example

tsmaeder commented 2 years ago

True, dat, but IMO moving CI deserves a separate issue: this is purely process help.

vogella commented 2 years ago

In any case you should document the "how to build JDT" process from the recent JDT discussions, its looks like even experience JDT developer have problems building JDT core on the command line. https://www.eclipse.org/lists/jdt-dev/msg02098.html

tsmaeder commented 2 years ago

That is a good idea, but my pronouns are we/us ;-) Feel free to open an issue to that effect.

vogella commented 2 years ago

That is a good idea, but my pronouns are we/us ;-) Feel free to open an issue to that effect.

I have no plans for this, belongs IMHO to this issue and if you disagree, that is fine for me. I just find it shocking that even JDT core developers have no idea no to build JDt core, and hence added this suggestion to your "lets improve contibutor documentation" issue.

tsmaeder commented 2 years ago

I just find it shocking that even JDT core developers have no idea no to build JDt core

Why would that be shocking? It's not a necessary step for developing JDT Core.

vogella commented 2 years ago

I just find it shocking that even JDT core developers have no idea no to build JDt core

Why would that be shocking? It's not a necessary step for developing JDT Core.

IMHO making the software easy to build is essential to be inviting to contributors. If you check the readmes I have created for the various platform repos other the years you find that I (almost9 always added the build instructions. to build the repo.

akurtakov commented 9 months ago

Done, except for codeowners which is a no-go now.