search

eclipse-jdt / eclipse.jdt.core

Eclipse Public License 2.0
157 stars 125 forks source link

[21] Code completion doesn't work inside String template expressions #1601

Open jarthana opened 10 months ago

jarthana commented 10 months ago

This should be tried on top of pull #1513

Any completion inside embedded expressions doesn't work. For e.g. this code:

    String s = STR."""
        \{  |  }
        """;

Initial investigation shows that jdt.ui doesn't recognize the location as valid place for Java constructs (i..e part of a string literal. Not sure if this needs to be fixed in the UI or core yet.

jarthana commented 5 months ago

This was fixed via pull #1712. I will just move the tests to compliance 23 in beta branch and close the issue.

srikanth-sankaran commented 5 months ago

This was fixed via pull #1712. I will just move the tests to compliance 23 in beta branch and close the issue.

Just a caution that that PR may only have fixed the problem for string templates and left the text block templates case as future work

jarthana commented 5 months ago

Just a caution that that PR may only have fixed the problem for string templates and left the text block templates case as future work Pull #1803 covered that.