search

eclipse-jdt / eclipse.jdt.core

Eclipse Public License 2.0
141 stars 107 forks source link

NPE in CodeStream.retrieveLocalType() #2438

Closed iloveeclipse closed 2 weeks ago

iloveeclipse commented 2 weeks ago

Fixes https://github.com/eclipse-jdt/eclipse.jdt.core/issues/2434

TODO: regression test

srikanth-sankaran commented 2 weeks ago

There are 4-5 enum tests that were noticed to fail locally. This is in my follow up tasks list.

srikanth-sankaran commented 2 weeks ago

See https://github.com/eclipse-jdt/eclipse.jdt.core/issues/2234#issuecomment-2100738652

srikanth-sankaran commented 2 weeks ago

See https://github.com/eclipse-jdt/eclipse.jdt.core/issues/2234#issuecomment-2100738652

These may in fact go away with the suggested fix. Let us see.

iloveeclipse commented 2 weeks ago

All tests are green. Closing this now (as it was only opened to see test results), @srikanth-sankaran will provide the right PR with regression test.