search

eclipse-jdt / eclipse.jdt.core

Eclipse Public License 2.0
156 stars 123 forks source link

TypePattern with both Type and name not working in some scenarios. #2741

Closed subyssurendran666 closed 1 month ago

subyssurendran666 commented 1 month ago

The bug is raised due to ticket raised in JDT.UI(https://github.com/eclipse-jdt/eclipse.jdt.ui/issues/1526#issuecomment-2244355863). There was some architectural changes has been done in the TypePattern in order to handled the unnamed pattern and variables. Which is done through https://github.com/eclipse-jdt/eclipse.jdt.core/issues/2623 and https://github.com/eclipse-jdt/eclipse.jdt.core/pull/2688.

Ensure following scenarios should work

  1. TypePattern with both type and name
  2. TypePattern with type and name as "_"
  3. TypePattern with name only(name as "_")
subyssurendran666 commented 1 month ago

The PR has been merged; therefore, I am closing the ticket.

carstenartur commented 1 month ago

Is this one supposed to fix the build issue in jdt ui?

subyssurendran666 commented 1 month ago

Is this one supposed to fix the build issue in jdt ui?

Yes I believe so. We have modified the TypePattern in the AST DOM in order to handle the Unnamed patterns and variables and that commit makes issues in the JDT.UI