TypePattern with both Type and name not working in some scenarios

[subyssurendran666]

What it does

https://github.com/eclipse-jdt/eclipse.jdt.core/issues/2741

How to test

Author checklist

• [x] I have thoroughly tested my changes
• [x] The change is following the coding conventions
• [x] I have signed the Eclipse Contributor Agreement (ECA)

[iloveeclipse]

It would really like to see meaningfull commit messages on every commit according to https://github.com/eclipse-jdt/.github/blob/main/CONTRIBUTING.md#commit-message-recommendations

[stephan-herrmann]

It would really like to see meaningfull commit messages on every commit according to https://github.com/eclipse-jdt/.github/blob/main/CONTRIBUTING.md#commit-message-recommendations

I fully agree regarding the first commit in a PR, but I wonder if follow-up commits (which will eventually be squashed anyway) are fine with a little less ceremony? Some explanation: yes, of course. But in that case I see little use in repeating the title, and perhaps even the footer can be omitted for secondary commits? @iloveeclipse WDYT?

Personally, I find it tiring to see the PR message template time and again with no added information except for an issue number.

[iloveeclipse]

Trivial commits do not need lengthy message but still should contain reference to the ticket they are supposed to fix or to contribute. Non trivial commits must explain the main idea of the change in the commit message.

"added fix" is not a commit message I personally would like to see in any valuable open source project, but is of course fully OK for the code in some private project.

For me, every commit should be self contained and self explaining, and that mandates following https://github.com/eclipse-jdt/.github/blob/main/CONTRIBUTING.md#commit-message-recommendations

[stephan-herrmann]

Trivial commits do not need lengthy message but still should contain reference to the ticket they are supposed to fix or to contribute. Non trivial commits must explain the main idea of the change in the commit message.

"added fix" is not a commit message I personally would like to see in any valuable open source project, but is of course fully OK for the code in some private project.

For me, every commit should be self contained and self explaining, and that mandates following https://github.com/eclipse-jdt/.github/blob/main/CONTRIBUTING.md#commit-message-recommendations

I'm fine concerning all but one small detail from the guide lines: even very respected committers don't always repeat the ticket title in every commit.

[iloveeclipse]

lines: even very respected committers don't always repeat the ticket title in every commit.

The PR in question looks like it is only because some other, much more respected committers don't like rebase :) So all commits after first three will disappear once the review is done.

Regarding ticket numner in the title in particular: as long as commit contains full ticket url it isn't actually needed. I will update guideline.

[subyssurendran666]

@iloveeclipse @stephan-herrmann I will add more meaningful commit messages from now on.