search

eclipse-jdt / eclipse.jdt.core

Eclipse Public License 2.0
156 stars 123 forks source link

JUnit test for setup where split package becomes child of plain package #2749

Closed PPazderski closed 1 month ago

PPazderski commented 1 month ago

unit test for #2748 (fails only if run with assertions enabled)

stephan-herrmann commented 1 month ago

The fix looks trivial: just one more location to treat auto modules like the unnamed module.

I'm not quite sure, though, about some details in existing code, relating to unnamed and automatic modules. One part has been outsourced to #2764.

Still I'll try to move the fix in this PR closer to the specification as I read it today.

stephan-herrmann commented 1 month ago

Still I'll try to move the fix in this PR closer to the specification as I read it today.

That failed, as now we are inconsistent regarding what an auto module reads. I reverted to the previous fix and leave the remaining issue to #2764 entirely.

I also slightly improved readability of the otherwise well-crafted test: use text blocks where possible :)

stephan-herrmann commented 1 month ago

Thanks @PPazderski !