[ ] [Stephan] Should this.currentProject.setOption(JavaCore.COMPILER_PB_RAW_TYPE_REFERENCE, JavaCore.IGNORE); be used in ConverterTestSetup.setUpJavaProject(String, String) ?
[ ] [Stephan]: change on BatchCompilerTest.testBridgeMethodRetention This change probably conflicts with the purpose of this test, @srikanth-sankaran ?
[ ] [Stephan] Change in ASTConverterTestAST8_2.test0612() caught me by surprise so I investigated:
the test implies to test AST at JLS8
using source from project Converter, Converter15, however, selects the AST level from the project.
@srikanth-sankaran , @jarthana does it make any sense have such tests here? Shouldn't tests always sit in a test class corresponding to the used Converter* project, e.g., ASTConverterAST3Test?
Open TODO's from https://github.com/eclipse-jdt/eclipse.jdt.core/pull/2551
Created issues:
Following questions wait for answering by others:
this.currentProject.setOption(JavaCore.COMPILER_PB_RAW_TYPE_REFERENCE, JavaCore.IGNORE);be used inConverterTestSetup.setUpJavaProject(String, String)?BatchCompilerTest.testBridgeMethodRetentionThis change probably conflicts with the purpose of this test, @srikanth-sankaran ?ASTConverterTestAST8_2.test0612()caught me by surprise so I investigated:Converter,Converter15, however, selects the AST level from the project. @srikanth-sankaran , @jarthana does it make any sense have such tests here? Shouldn't tests always sit in a test class corresponding to the usedConverter*project, e.g.,ASTConverterAST3Test?